From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Zqprz-0001on-BV for mharc-grub-devel@gnu.org; Mon, 26 Oct 2015 18:03:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zqprv-0001lB-Lc for grub-devel@gnu.org; Mon, 26 Oct 2015 18:03:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zqpru-0004vh-Pl for grub-devel@gnu.org; Mon, 26 Oct 2015 18:03:55 -0400 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:36143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zqpru-0004uz-Ig for grub-devel@gnu.org; Mon, 26 Oct 2015 18:03:54 -0400 Received: by wicfx6 with SMTP id fx6so134201284wic.1 for ; Mon, 26 Oct 2015 15:03:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type; bh=5dQkrBofZK8VsiLiQnjRSv2u3hqypBKg3eKkmKYkbBE=; b=OWPPmWDfQzrkAd9Go50BHqqNeAwmtJuQ7axeQl2xunSCl7i58kgW4u4tX1hS3rvN/c OhnDfpn3izrjpRYzjaRUFHRav6ujEe979JK6SKryNSWPvnFjdtoi2EH4lXJkF44IUwqO 74e3OTGEClCjGxRUOJfeYwN3sm62iBdYXjHh+qqYyszUDIeCeXnVkpvQnmKpOyWfvmJQ jWnn+kcWkgmoIkh5Yv+2Rio+CJogs49SwRkTypjzRxxyIspFCXb8mMTFWhzpPJYibDTo XoIHW3QFfYkhu/kE6Mq+h29FR9RkMXoqKT9hH87QbGF7h58hCQh1oJsl9QgytQZJFPnc Yxjw== X-Received: by 10.180.189.18 with SMTP id ge18mr2793000wic.95.1445897033861; Mon, 26 Oct 2015 15:03:53 -0700 (PDT) Received: from ?IPv6:2a02:1205:34c8:dc00:863a:4bff:fe50:abc4? ([2a02:1205:34c8:dc00:863a:4bff:fe50:abc4]) by smtp.gmail.com with ESMTPSA id lv4sm41309305wjb.43.2015.10.26.15.03.53 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Oct 2015 15:03:53 -0700 (PDT) Subject: Re: [PATCH 2/3] ieee1275: ofdisk memory leak To: The development of GNU GRUB References: <1671671c705298f7d6e8c7e79805564b3b662548.1445895272.git.eric.snowberg@oracle.com> <47d14c14670ca8604c76e157f66251ba70bc91f2.1445895272.git.eric.snowberg@oracle.com> From: =?UTF-8?Q?Vladimir_'=cf=86-coder/phcoder'_Serbinenko?= Message-ID: <562EA348.4060509@gmail.com> Date: Mon, 26 Oct 2015 23:03:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.2.0 MIME-Version: 1.0 In-Reply-To: <47d14c14670ca8604c76e157f66251ba70bc91f2.1445895272.git.eric.snowberg@oracle.com> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sdQ0sqcmtmARTv7KHDHjo5BBgeOS0FB1B" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::234 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2015 22:03:56 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sdQ0sqcmtmARTv7KHDHjo5BBgeOS0FB1B Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 26.10.2015 22:43, Eric Snowberg wrote: > Fix memory leak added within commit: > 87ec3b7fa9061f470616ed927fc140e995831c00 - "Don't continue to > query block-size if disk doesn't have it.=E2=80=9D >=20 Committed, thanks > Signed-off-by: Eric Snowberg > --- > grub-core/disk/ieee1275/ofdisk.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) >=20 > diff --git a/grub-core/disk/ieee1275/ofdisk.c b/grub-core/disk/ieee1275= /ofdisk.c > index 4a5632c..297f058 100644 > --- a/grub-core/disk/ieee1275/ofdisk.c > +++ b/grub-core/disk/ieee1275/ofdisk.c > @@ -432,7 +432,10 @@ grub_ofdisk_open (const char *name, grub_disk_t di= sk) > =20 > err =3D grub_ofdisk_get_block_size (devpath, &block_size, op); > if (err) > - return err; > + { > + grub_free (devpath); > + return err; > + } > if (block_size !=3D 0) > { > for (disk->log_sector_size =3D 0; > @@ -443,6 +446,7 @@ grub_ofdisk_open (const char *name, grub_disk_t dis= k) > disk->log_sector_size =3D 9; > } > =20 > + grub_free (devpath); > return 0; > } > =20 >=20 --sdQ0sqcmtmARTv7KHDHjo5BBgeOS0FB1B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREKAAYFAlYuo0gACgkQmBXlbbo5nOsr1QD8DnFfA8IWcuzRBxxv6BMvIoAH UqpDaka1X1OraTDauzQA+gNfAgMEAJoKmT8S79MqkAUfPlW2kg7VZ9WYZV4/RIz3 =GD4e -----END PGP SIGNATURE----- --sdQ0sqcmtmARTv7KHDHjo5BBgeOS0FB1B--