From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-kernel@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Scott Branden <sbranden@broadcom.com>,
linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: versatile: Make depend on OF when COMPILE_TEST
Date: Tue, 27 Oct 2015 07:04:21 +0900 [thread overview]
Message-ID: <562EA365.5080704@osg.samsung.com> (raw)
In-Reply-To: <20151026185142.GF19782@codeaurora.org>
Hello Stephen,
On 10/27/2015 03:51 AM, Stephen Boyd wrote:
> On 10/26, Javier Martinez Canillas wrote:
>> Commit 4a7748c3d641 ("clk: Allow drivers to build if COMPILE_TEST is
>> enabled") allowed clk drives to be compile tested on other archs but
>
> s/drives/drivers/
>
>> the COMMON_CLK_VERSATILE was only enabled on platforms that already
>> selected OF support so the drivers assume it will always be enabled.
>>
>> So, restrict compile test for these drivers only if OF is enabled.
>
> No compiler error message?
>
>>
>> Fixes: 4a7748c3d641 ("clk: Allow drivers to build if COMPILE_TEST is enabled")
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>
> No Reported-by?
>
Yes, sorry for forgetting the Reported-by and the build error...
> I'd prefer we add stubs instead, so I've applied the patch below.
>
Great, thanks!
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
prev parent reply other threads:[~2015-10-26 22:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-25 22:41 [PATCH] clk: versatile: Make depend on OF when COMPILE_TEST Javier Martinez Canillas
2015-10-26 9:02 ` Geert Uytterhoeven
2015-10-26 14:44 ` Javier Martinez Canillas
2015-10-26 18:51 ` Stephen Boyd
2015-10-26 22:04 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562EA365.5080704@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.