From: Laura Abbott <labbott@redhat.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
linux-kernel@vger.kernel.org
Cc: Wolfram Sang <wsa@the-dreams.de>,
Lee Jones <lee.jones@linaro.org>, Joe Perches <joe@perches.com>
Subject: Re: [PATCH] get_maintainer: Don't fallback to git by default
Date: Mon, 26 Oct 2015 16:00:11 -0700 [thread overview]
Message-ID: <562EB07B.9040501@redhat.com> (raw)
In-Reply-To: <1445897508-16528-1-git-send-email-javier@osg.samsung.com>
On 10/26/2015 03:11 PM, Javier Martinez Canillas wrote:
> The get_maintainer.pl script could be used to get a list of people that
> has to be in the copy list when posting patches for a given file but it
> defaults to git fallback so the list returned isn't really relevant and
> submitters are posting patches to random developers that just happened
> to touch that file in the past.
>
> Disable git fallback so get_maintainer.pl only returns the information
> that is in MAINTAINERS by default.
>
> Suggested-by: Wolfram Sang <wsa@the-dreams.de>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
> Hello,
>
> This patch was suggested by Wolfram on this thread [0] but it is
> something I thought before because I've seen people complaining
> on a regular basis about being cc'ed in random patches and there
> are tools like patman [1] that rely on get_maintainers.pl to post
> the patches.
>
> [0]: https://lkml.org/lkml/2015/10/26/444
> [1]: http://git.denx.de/?p=u-boot.git;a=blob;f=tools/patman/README
>
> Best regards,
> Javier
>
We might need to do a sweep of files to make sure more of them are
listed in the maintainers file, else by default they only show LKML.
As an example, a bunch of files in lib are only showing LKML.
Defaulting to only sending to LKML may be swinging too far in the wrong
direction for reducing inbox size.
> scripts/get_maintainer.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 98bae869f6d0..b52ae26270e8 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -29,7 +29,7 @@ my $email_git = 0;
> my $email_git_all_signature_types = 0;
> my $email_git_blame = 0;
> my $email_git_blame_signatures = 1;
> -my $email_git_fallback = 1;
> +my $email_git_fallback = 0;
> my $email_git_min_signatures = 1;
> my $email_git_max_maintainers = 5;
> my $email_git_min_percent = 5;
>
next prev parent reply other threads:[~2015-10-26 23:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 22:11 [PATCH] get_maintainer: Don't fallback to git by default Javier Martinez Canillas
2015-10-26 23:00 ` Laura Abbott [this message]
2015-10-27 0:08 ` Javier Martinez Canillas
2015-10-27 2:47 ` Theodore Ts'o
2015-10-27 4:57 ` joe
2015-10-27 5:03 ` Laura Abbott
2015-10-27 8:21 ` Lee Jones
2015-10-27 9:24 ` Wolfram Sang
2015-10-27 10:10 ` Lee Jones
2015-10-27 10:29 ` Wolfram Sang
2015-10-27 17:49 ` Joe Perches
2015-10-27 18:21 ` Joe Perches
2015-10-27 23:25 ` Wolfram Sang
2015-10-27 23:37 ` Joe Perches
2015-10-28 0:05 ` Wolfram Sang
2015-10-28 0:14 ` Joe Perches
2015-10-28 8:50 ` Lee Jones
2015-10-27 17:53 ` Joe Perches
2015-10-27 18:09 ` Lee Jones
2015-10-27 19:24 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562EB07B.9040501@redhat.com \
--to=labbott@redhat.com \
--cc=javier@osg.samsung.com \
--cc=joe@perches.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.