From: Phil Reid <preid@electromag.com.au>
To: netdev@vger.kernel.org
Cc: peppe.cavallaro@st.com
Subject: stmmac: Reporting ethtool_ts_info
Date: Tue, 27 Oct 2015 14:11:03 +0800 [thread overview]
Message-ID: <562F1577.8040803@electromag.com.au> (raw)
G'day All,
The stmmac driver checks (priv->hwts_tx_en) && (priv->hwts_rx_en) before
reporting WHTSTAMP capabilities.
No other driver seems to do this. hwts_*_en indicate if timestamping is
enabled, not if the interface is capable of it.
Instead they check there capabilities. Which would be
(priv->dma_cap.time_stamp || priv->dma_cap.atime_stamp)
Does this seem reasonable?
--
Regards
Phil Reid
next reply other threads:[~2015-10-27 6:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 6:11 Phil Reid [this message]
2015-10-30 5:15 ` stmmac: Reporting ethtool_ts_info Rayagond Kokatanur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562F1577.8040803@electromag.com.au \
--to=preid@electromag.com.au \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.