All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Schmitz <schmitzmic@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@vger.kernel.org
Subject: Re: atakbd_keycode
Date: Tue, 27 Oct 2015 20:40:19 +1300	[thread overview]
Message-ID: <562F2A63.20105@gmail.com> (raw)
In-Reply-To: <87h9lgwfra.fsf@igel.home>

Andreas,

you're certainly right there - I used the German keyboard to figure out
the mapping (that's where the FIXMEs are from) and must have looked at a
PC keyboard for some of the DE-US translation.

Thanks for spotting this. I'll better double check the entire keymap
before preparing a patch ...

Cheers,

    Michael


Am 25.10.15 um 02:35 schrieb Andreas Schwab:
> In drivers/input/keyboard/atakbd.c, the array atakbd_keycode is
> initialized like this:
>
> 	[41]	 = KEY_BACKSLASH,	/* FIXME, '#' */
> 	[43]	 = KEY_GRAVE,		/* FIXME: '~' */
>
> Shouldn't that be the other way round?  According to the Profibuch, on a
> US Atari keyboard the key which sends scancode 41 is the '`' key and the
> scancode 43 is sent by the '\' key.  On a German keyboard, these are the
> '#' and '~' keys, resp.
>
> Andreas.
>

      reply	other threads:[~2015-10-27  7:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-24 13:35 atakbd_keycode Andreas Schwab
2015-10-27  7:40 ` Michael Schmitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562F2A63.20105@gmail.com \
    --to=schmitzmic@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.