From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Subject: Re: [PATCH v2 0/2] ARM: OMAP2+ McASP(3) support for DRA7xx family Date: Tue, 27 Oct 2015 10:37:37 +0200 Message-ID: <562F37D1.8030105@ti.com> References: <1444814608-20908-1-git-send-email-peter.ujfalusi@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1444814608-20908-1-git-send-email-peter.ujfalusi@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: tony@atomide.com, paul@pwsan.com Cc: t-kristo@ti.com, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org Hi Paul, On 10/14/2015 12:23 PM, Peter Ujfalusi wrote: > Hi Paul, > = > This is the followup series for the hwmod changes needed to get audio wor= king > on DRA7xx family based boards. > The DTS patches has been applied by Tony from the original series: > http://www.spinics.net/lists/linux-omap/msg121473.html > = > I have addressed your comments in the hwmod data and did some research al= so > regarding to the use of ahclkx as fclk in the original submission. > It turned out that McASP _needs_ all clocks to be enabled (fclk, iclk and > ahclkx/r) to be able to access registers. The original patch where we han= dled > the ahclkx as fclk worked, because the fclk clock got enabled in the HW w= /o > any SW interaction. > All in all, the McASP found in DRA7 needs all clocks to be enabled. > To satisfy this I have introduced a new flag to hwmod, which means that t= he > listed optional clocks need to be handled alongside with the fclk clock. Can you, please look at this patch? Thank you, P=E9ter > = > Regards, > Peter > --- > Peter Ujfalusi (2): > ARM: OMAP2+: hwmod: Add hwmod flag for HWMOD_OPT_CLKS_NEEDED > ARM: OMAP: DRA7: hwmod: Add data for McASP3 > = > arch/arm/mach-omap2/omap_hwmod.c | 66 +++++++++++++++++--------= ------ > arch/arm/mach-omap2/omap_hwmod.h | 3 ++ > arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 56 ++++++++++++++++++++++++++ > 3 files changed, 95 insertions(+), 30 deletions(-) > = From mboxrd@z Thu Jan 1 00:00:00 1970 From: peter.ujfalusi@ti.com (Peter Ujfalusi) Date: Tue, 27 Oct 2015 10:37:37 +0200 Subject: [PATCH v2 0/2] ARM: OMAP2+ McASP(3) support for DRA7xx family In-Reply-To: <1444814608-20908-1-git-send-email-peter.ujfalusi@ti.com> References: <1444814608-20908-1-git-send-email-peter.ujfalusi@ti.com> Message-ID: <562F37D1.8030105@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Paul, On 10/14/2015 12:23 PM, Peter Ujfalusi wrote: > Hi Paul, > > This is the followup series for the hwmod changes needed to get audio working > on DRA7xx family based boards. > The DTS patches has been applied by Tony from the original series: > http://www.spinics.net/lists/linux-omap/msg121473.html > > I have addressed your comments in the hwmod data and did some research also > regarding to the use of ahclkx as fclk in the original submission. > It turned out that McASP _needs_ all clocks to be enabled (fclk, iclk and > ahclkx/r) to be able to access registers. The original patch where we handled > the ahclkx as fclk worked, because the fclk clock got enabled in the HW w/o > any SW interaction. > All in all, the McASP found in DRA7 needs all clocks to be enabled. > To satisfy this I have introduced a new flag to hwmod, which means that the > listed optional clocks need to be handled alongside with the fclk clock. Can you, please look at this patch? Thank you, P?ter > > Regards, > Peter > --- > Peter Ujfalusi (2): > ARM: OMAP2+: hwmod: Add hwmod flag for HWMOD_OPT_CLKS_NEEDED > ARM: OMAP: DRA7: hwmod: Add data for McASP3 > > arch/arm/mach-omap2/omap_hwmod.c | 66 +++++++++++++++++-------------- > arch/arm/mach-omap2/omap_hwmod.h | 3 ++ > arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 56 ++++++++++++++++++++++++++ > 3 files changed, 95 insertions(+), 30 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754316AbbJ0Iii (ORCPT ); Tue, 27 Oct 2015 04:38:38 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:44412 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752138AbbJ0IiG (ORCPT ); Tue, 27 Oct 2015 04:38:06 -0400 Subject: Re: [PATCH v2 0/2] ARM: OMAP2+ McASP(3) support for DRA7xx family To: , References: <1444814608-20908-1-git-send-email-peter.ujfalusi@ti.com> CC: , , , From: Peter Ujfalusi Message-ID: <562F37D1.8030105@ti.com> Date: Tue, 27 Oct 2015 10:37:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1444814608-20908-1-git-send-email-peter.ujfalusi@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, On 10/14/2015 12:23 PM, Peter Ujfalusi wrote: > Hi Paul, > > This is the followup series for the hwmod changes needed to get audio working > on DRA7xx family based boards. > The DTS patches has been applied by Tony from the original series: > http://www.spinics.net/lists/linux-omap/msg121473.html > > I have addressed your comments in the hwmod data and did some research also > regarding to the use of ahclkx as fclk in the original submission. > It turned out that McASP _needs_ all clocks to be enabled (fclk, iclk and > ahclkx/r) to be able to access registers. The original patch where we handled > the ahclkx as fclk worked, because the fclk clock got enabled in the HW w/o > any SW interaction. > All in all, the McASP found in DRA7 needs all clocks to be enabled. > To satisfy this I have introduced a new flag to hwmod, which means that the > listed optional clocks need to be handled alongside with the fclk clock. Can you, please look at this patch? Thank you, Péter > > Regards, > Peter > --- > Peter Ujfalusi (2): > ARM: OMAP2+: hwmod: Add hwmod flag for HWMOD_OPT_CLKS_NEEDED > ARM: OMAP: DRA7: hwmod: Add data for McASP3 > > arch/arm/mach-omap2/omap_hwmod.c | 66 +++++++++++++++++-------------- > arch/arm/mach-omap2/omap_hwmod.h | 3 ++ > arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 56 ++++++++++++++++++++++++++ > 3 files changed, 95 insertions(+), 30 deletions(-) >