From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Burian Subject: Re: No backlight since linux-4.2.4 - drivers/gpu/drm/radeon/atombios_encoders.c Date: Tue, 27 Oct 2015 09:44:12 +0100 Message-ID: <562F395C.2080109@sbg.at> References: <562BDB47.5000301@sbg.at> <562DF333.3070708@daenzer.net> <562E0473.5060404@sbg.at> <562EE34A.9070100@daenzer.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------090403060604040007010200" Return-path: Received: from smtp.cablelink.at (smtp.cablelink.at [213.153.32.141]) by gabe.freedesktop.org (Postfix) with ESMTPS id 44F176E4EA for ; Tue, 27 Oct 2015 02:02:30 -0700 (PDT) In-Reply-To: <562EE34A.9070100@daenzer.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?B?TWljaGVsIETDpG56ZXI=?= Cc: "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org This is a multi-part message in MIME format. --------------090403060604040007010200 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/27/15 03:36, Michel D=C3=A4nzer wrote: >> >> [0] contains dmesg output with your patch applied (which fixes the bac= klight issue) >=20 > This is very surprising: The patch just adds some debugging output, it'= s > not supposed to have any functional effect. Also, I don't see any of th= e > debugging output added by the patch in > dmesg-4.3.0-rc7-00003-g85051e2-dirty-2015-10-26-11-00-41-radeon-bl-debu= g. > > Are you sure that my patch was actually applied to the radeon driver > when generating that file? Did you update the initrd with the patched > radeon.ko? >=20 the build was done using "make -j4 deb-pkg" on a better equipped machine, .deb packages were copied over and installed - maybe something interestin= g happened AFAICT the patch should have been applied, at least it was shown with git diff and the -dirty suffix was added by the build system, not me. All graphics related drivers are compiled in (=3Dy) rather than as modules (=3Dm) in .config. Another thing I tried yesterday was to add the old way right below the ne= w one (this fixes the backlight issue) enclosed by some debug statements that i= ndicate start / stop of the old / new method. (see atomdebug.diff - should be app= lied against mainline) --------------090403060604040007010200 Content-Type: text/plain; charset=us-ascii; name="new.nots" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="new.nots" cmFkZW9uX3N0YXJ0X2JhY2tsaWdodF9uZXdfd2F5Cj4+IGV4ZWN1dGUgRDJBQSAobGVuIDM0 OCwgV1MgNCwgUFMgNCkKICAgU0VUX0FUSV9QT1JUIEAgMHhEMkIwCiAgICAgIHBvcnQ6IDAg KE1NKQogICBDT01QQVJFX1BTIEAgMHhEMkIzCiAgICAgIHNyYzE6IApQU1sweDAwLDB4RkZG Rjg4MDJdCi5bNzowXSAtPiAweDAyCiAgICAgIHNyYzI6IApJTU0gMHgwNAogICAgICByZXN1 bHQ6IE5FIExFCiAgIEpVTVBfRVFVQUwgQCAweEQyQjcKICAgICAgdGFrZW46IG5vCiAgICAg IHRhcmdldDogMHgwMTI4CiAgIENPTVBBUkVfUFMgQCAweEQyQkEKICAgICAgc3JjMTogClBT WzB4MDAsMHhGRkZGODgwMl0KLls3OjBdIC0+IDB4MDIKICAgICAgc3JjMjogCklNTSAweDA1 CiAgICAgIHJlc3VsdDogTkUgTEUKICAgSlVNUF9FUVVBTCBAIDB4RDJCRQogICAgICB0YWtl bjogbm8KICAgICAgdGFyZ2V0OiAweDAxMTMKICAgQ09NUEFSRV9QUyBAIDB4RDJDMQogICAg ICBzcmMxOiAKUFNbMHgwMCwweEZGRkY4ODAyXQouWzc6MF0gLT4gMHgwMgogICAgICBzcmMy OiAKSU1NIDB4MDAKICAgICAgcmVzdWx0OiBORSBHVAogICBKVU1QX0VRVUFMIEAgMHhEMkM1 CiAgICAgIHRha2VuOiBubwogICAgICB0YXJnZXQ6IDB4MDBEOAogICBDT01QQVJFX1BTIEAg MHhEMkM4CiAgICAgIHNyYzE6IApQU1sweDAwLDB4RkZGRjg4MDJdCi5bNzowXSAtPiAweDAy CiAgICAgIHNyYzI6IApJTU0gMHgwMQogICAgICByZXN1bHQ6IE5FIEdUCiAgIEpVTVBfTk9U X0VRVUFMIEAgMHhEMkNDCiAgICAgIHRha2VuOiB5ZXMKICAgICAgdGFyZ2V0OiAweDAxM0QK ICAgQ09NUEFSRV9QUyBAIDB4RDNFNwogICAgICBzcmMxOiAKUFNbMHgwMCwweEZGRkY4ODAy XQouWzc6MF0gLT4gMHgwMgogICAgICBzcmMyOiAKSU1NIDB4MDMKICAgICAgcmVzdWx0OiBO RSBMRQogICBKVU1QX05PVF9FUVVBTCBAIDB4RDNFQgogICAgICB0YWtlbjogeWVzCiAgICAg IHRhcmdldDogMHgwMTUxCiAgIE9SX1JFRyBAIDB4RDNGQgogICAgICBkc3Q6IApSRUdbMHgx RUJDXQouWzMxOjI0XSAtPiAweDAwCiAgICAgIHNyYzogCklNTSAweDAyCiAgICAgIGRzdDog ClJFR1sweDFFQkNdCi5bMzE6MjRdIDwtIDB4MDIKICAgQU5EX1JFRyBAIDB4RDQwMAogICAg ICBkc3Q6IApSRUdbMHgxRUJDXQouWzMxOjI0XSAtPiAweDAyCiAgICAgIHNyYzogCklNTSAw eEZFCiAgICAgIGRzdDogClJFR1sweDFFQkNdCi5bMzE6MjRdIDwtIDB4MDIKICAgRU9UIEAg MHhENDA1Cjw8CnJhZGVvbl9zdG9wX2JhY2tsaWdodF9uZXdfd2F5cmFkZW9uX3N0YXJ0X2Jh Y2tsaWdodF9vbGRfd2F5Cg== --------------090403060604040007010200 Content-Type: text/plain; charset=us-ascii; name="old.nots" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="old.nots" cmFkZW9uX3N0b3BfYmFja2xpZ2h0X25ld193YXlyYWRlb25fc3RhcnRfYmFja2xpZ2h0X29s ZF93YXkKPj4gZXhlY3V0ZSBEMkFBIChsZW4gMzQ4LCBXUyA0LCBQUyA0KQogICBTRVRfQVRJ X1BPUlQgQCAweEQyQjAKICAgICAgcG9ydDogMCAoTU0pCiAgIENPTVBBUkVfUFMgQCAweEQy QjMKICAgICAgc3JjMTogClBTWzB4MDAsMHgwMDAzXQouWzc6MF0gLT4gMHgwMwogICAgICBz cmMyOiAKSU1NIDB4MDQKICAgICAgcmVzdWx0OiBORSBMRQogICBKVU1QX0VRVUFMIEAgMHhE MkI3CiAgICAgIHRha2VuOiBubwogICAgICB0YXJnZXQ6IDB4MDEyOAogICBDT01QQVJFX1BT IEAgMHhEMkJBCiAgICAgIHNyYzE6IApQU1sweDAwLDB4MDAwM10KLls3OjBdIC0+IDB4MDMK ICAgICAgc3JjMjogCklNTSAweDA1CiAgICAgIHJlc3VsdDogTkUgTEUKICAgSlVNUF9FUVVB TCBAIDB4RDJCRQogICAgICB0YWtlbjogbm8KICAgICAgdGFyZ2V0OiAweDAxMTMKICAgQ09N UEFSRV9QUyBAIDB4RDJDMQogICAgICBzcmMxOiAKUFNbMHgwMCwweDAwMDNdCi5bNzowXSAt PiAweDAzCiAgICAgIHNyYzI6IApJTU0gMHgwMAogICAgICByZXN1bHQ6IE5FIEdUCiAgIEpV TVBfRVFVQUwgQCAweEQyQzUKICAgICAgdGFrZW46IG5vCiAgICAgIHRhcmdldDogMHgwMEQ4 CiAgIENPTVBBUkVfUFMgQCAweEQyQzgKICAgICAgc3JjMTogClBTWzB4MDAsMHgwMDAzXQou Wzc6MF0gLT4gMHgwMwogICAgICBzcmMyOiAKSU1NIDB4MDEKICAgICAgcmVzdWx0OiBORSBH VAogICBKVU1QX05PVF9FUVVBTCBAIDB4RDJDQwogICAgICB0YWtlbjogeWVzCiAgICAgIHRh cmdldDogMHgwMTNECiAgIENPTVBBUkVfUFMgQCAweEQzRTcKICAgICAgc3JjMTogClBTWzB4 MDAsMHgwMDAzXQouWzc6MF0gLT4gMHgwMwogICAgICBzcmMyOiAKSU1NIDB4MDMKICAgICAg cmVzdWx0OiBFUSBMRQogICBKVU1QX05PVF9FUVVBTCBAIDB4RDNFQgogICAgICB0YWtlbjog bm8KICAgICAgdGFyZ2V0OiAweDAxNTEKICAgT1JfUkVHIEAgMHhEM0VFCiAgICAgIGRzdDog ClJFR1sweDFFQkNdCi5bMzE6MjRdIC0+IDB4MDIKICAgICAgc3JjOiAKSU1NIDB4MDIKICAg ICAgZHN0OiAKUkVHWzB4MUVCQ10KLlszMToyNF0gPC0gMHgwMgogICBPUl9SRUcgQCAweEQz RjMKICAgICAgZHN0OiAKUkVHWzB4MUVCQ10KLlszMToyNF0gLT4gMHgwMgogICAgICBzcmM6 IApJTU0gMHgwMQogICAgICBkc3Q6IApSRUdbMHgxRUJDXQouWzMxOjI0XSA8LSAweDAzCiAg IEpVTVAgQCAweEQzRjgKICAgICAgdGFyZ2V0OiAweDAxNUIKICAgRU9UIEAgMHhENDA1Cjw8 CnJhZGVvbl9zdG9wX2JhY2tsaWdodF9vbGRfd2F5Cg== --------------090403060604040007010200 Content-Type: text/x-patch; name="atomdebug.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="atomdebug.diff" diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c index ec1593a..a626bd6 100644 --- a/drivers/gpu/drm/radeon/atom.c +++ b/drivers/gpu/drm/radeon/atom.c @@ -62,7 +62,7 @@ typedef struct { bool abort; } atom_exec_context; -int atom_debug = 0; +int atom_debug = 1; static int atom_execute_table_locked(struct atom_context *ctx, int index, uint32_t * params); int atom_execute_table(struct atom_context *ctx, int index, uint32_t * params); diff --git a/drivers/gpu/drm/radeon/atombios_encoders.c b/drivers/gpu/drm/radeon/atombios_encoders.c index 65adb9c..c0d874f 100644 --- a/drivers/gpu/drm/radeon/atombios_encoders.c +++ b/drivers/gpu/drm/radeon/atombios_encoders.c @@ -1624,9 +1624,15 @@ radeon_atom_encoder_dpms_avivo(struct drm_encoder *encoder, int mode) } else atom_execute_table(rdev->mode_info.atom_context, index, (uint32_t *)&args); if (radeon_encoder->devices & (ATOM_DEVICE_LCD_SUPPORT)) { + printk("radeon_start_backlight_new_way"); struct radeon_encoder_atom_dig *dig = radeon_encoder->enc_priv; - atombios_set_backlight_level(radeon_encoder, dig->backlight_level); + printk("radeon_stop_backlight_new_way"); + + printk("radeon_start_backlight_old_way"); + args.ucAction = ATOM_LCD_BLON; + atom_execute_table(rdev->mode_info.atom_context, index, (uint32_t *)&args); + printk("radeon_stop_backlight_old_way"); } break; case DRM_MODE_DPMS_STANDBY: --------------090403060604040007010200 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --------------090403060604040007010200--