From: Julien Grall <julien.grall@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
Oleksandr Tyshchenko <oleksandr.tyshchenko@globallogic.com>
Cc: xen-devel@lists.xen.org, tim@xen.org, ian.campbell@citrix.com,
stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH v1] xen/serial: Return actual bytes stored in TX FIFO for OMAP
Date: Tue, 27 Oct 2015 10:54:49 +0000 [thread overview]
Message-ID: <562F57F9.1020805@citrix.com> (raw)
In-Reply-To: <562F652102000078000AF061@prv-mh.provo.novell.com>
On 27/10/15 10:50, Jan Beulich wrote:
>>>> On 27.10.15 at 11:36, <oleksandr.tyshchenko@globallogic.com> wrote:
>> --- a/xen/include/xen/8250-uart.h
>> +++ b/xen/include/xen/8250-uart.h
>> @@ -143,6 +143,15 @@
>> /* Supplementary control register */
>> #define UART_OMAP_SCR 0x10
>
> I think this one is already misplaced here (as is the one in the context
> below the change).
I don't think so, the omap UART is based on the 8250 and share some
common registers.
FWIW, we do the same for ns16550.c which is using the 8250 headers...
Regards,
--
Julien Grall
next prev parent reply other threads:[~2015-10-27 10:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 10:36 [PATCH v1] xen/serial: Return actual bytes stored in TX FIFO for OMAP Oleksandr Tyshchenko
2015-10-27 10:50 ` Jan Beulich
2015-10-27 10:54 ` Julien Grall [this message]
2015-10-27 11:05 ` Jan Beulich
2015-10-27 11:15 ` Julien Grall
2015-10-27 11:33 ` Oleksandr Tyshchenko
2015-10-27 16:32 ` Oleksandr Tyshchenko
2015-10-27 16:40 ` Jan Beulich
2015-11-03 16:36 ` Ian Campbell
2015-11-04 16:09 ` Oleksandr Tyshchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562F57F9.1020805@citrix.com \
--to=julien.grall@citrix.com \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=oleksandr.tyshchenko@globallogic.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.