From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] xen/mm: Improve message in populate physmap
 when the domain is direct mapped
Date: Tue, 27 Oct 2015 11:45:18 +0000
Message-ID: <562F63CE.7090806@citrix.com>
References: <1445945637-26421-1-git-send-email-julien.grall@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=7357aa5aa=Andrew.Cooper3@citrix.com>)
	id 1Zr2gt-0006BJ-8Q
	for xen-devel@lists.xenproject.org; Tue, 27 Oct 2015 11:45:23 +0000
In-Reply-To: <1445945637-26421-1-git-send-email-julien.grall@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@citrix.com>, xen-devel@lists.xenproject.org
Cc: Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>, ian.campbell@citrix.com, Jan Beulich <jbeulich@suse.com>, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On 27/10/15 11:33, Julien Grall wrote:
> The current domain and the domain pointed by the variable "d" are not
> the same.
>
> However, when it's not possible to get a reference on the page, the
> target domain ID is not printed. This makes the message difficult to
> understand.
>
> Improve the message by printing the target domain ID.
>
> Signed-off-by: Julien Grall <julien.grall@citrix.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>, with a
suggestion as well.

>
> ---
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Keir Fraser <keir@xen.org>
> Cc: Tim Deegan <tim@xen.org>
> ---
>  xen/common/memory.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/common/memory.c b/xen/common/memory.c
> index f6aed0d..206955f 100644
> --- a/xen/common/memory.c
> +++ b/xen/common/memory.c
> @@ -141,7 +141,7 @@ static void populate_physmap(struct memop_args *a)
>                      {
>                          gdprintk(XENLOG_INFO,
>                                   "mfn %#"PRI_xen_pfn" doesn't belong to the"
> -                                 " domain\n", mfn);
> +                                 " domain %d\n", mfn, d->domain_id);

This could easily be shortened to "doesn't belong to d%d" which matches
our other domain identification.

~Andrew