From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] xen/mm: Improve message in populate physmap when the domain is direct mapped Date: Tue, 27 Oct 2015 12:09:33 +0000 Message-ID: <562F697D.2000609@citrix.com> References: <1445945637-26421-1-git-send-email-julien.grall@citrix.com> <562F63CE.7090806@citrix.com> <562F64E3.4090606@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr34M-0007b0-LG for xen-devel@lists.xenproject.org; Tue, 27 Oct 2015 12:09:39 +0000 In-Reply-To: <562F64E3.4090606@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , xen-devel@lists.xenproject.org Cc: Keir Fraser , Tim Deegan , ian.campbell@citrix.com, Jan Beulich , stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 27/10/15 11:49, Julien Grall wrote: > Hi Andrew, > > On 27/10/15 11:45, Andrew Cooper wrote: >> On 27/10/15 11:33, Julien Grall wrote: >>> The current domain and the domain pointed by the variable "d" are not >>> the same. >>> >>> However, when it's not possible to get a reference on the page, the >>> target domain ID is not printed. This makes the message difficult to >>> understand. >>> >>> Improve the message by printing the target domain ID. >>> >>> Signed-off-by: Julien Grall >> Reviewed-by: Andrew Cooper , with a >> suggestion as well. >> >>> --- >>> Cc: Ian Campbell >>> Cc: Jan Beulich >>> Cc: Keir Fraser >>> Cc: Tim Deegan >>> --- >>> xen/common/memory.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/xen/common/memory.c b/xen/common/memory.c >>> index f6aed0d..206955f 100644 >>> --- a/xen/common/memory.c >>> +++ b/xen/common/memory.c >>> @@ -141,7 +141,7 @@ static void populate_physmap(struct memop_args *a) >>> { >>> gdprintk(XENLOG_INFO, >>> "mfn %#"PRI_xen_pfn" doesn't belong to the" >>> - " domain\n", mfn); >>> + " domain %d\n", mfn, d->domain_id); >> This could easily be shortened to "doesn't belong to d%d" which matches >> our other domain identification. > I also just noticed that the message is split between 2 lines. IIRC, we > are trying to avoid that to allow grep working. > > I will resend this patch with: > > gprintk(XENLOG_INFO, > "mfn %#"PRI_xen_pfn" doesn't belong to d%d\n", > mfn, d->domain_id). > > Can I keep your reviewed-by with that change? Certainly. ~Andrew