From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Murphy Subject: Re: [PATCH v5 4/6] memory: mediatek: Add SMI driver Date: Tue, 27 Oct 2015 13:24:34 +0000 Message-ID: <562F7B12.7030201@arm.com> References: <1444357388-30257-1-git-send-email-yong.wu@mediatek.com> <1444357388-30257-5-git-send-email-yong.wu@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <1444357388-30257-5-git-send-email-yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yong Wu , Joerg Roedel , Thierry Reding , Mark Rutland , Matthias Brugger Cc: Will Deacon , Daniel Kurtz , Tomasz Figa , Lucas Stach , Rob Herring , Catalin Marinas , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sasha Hauer , srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, mitchelh-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, Sricharan R , youhua.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, k.zhang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, kendrick.hsu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org List-Id: iommu@lists.linux-foundation.org On 09/10/15 03:23, Yong Wu wrote: [...] > +static int mtk_smi_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct mtk_smi_data *smidata; > + int ret; > + > + if (!dev->pm_domain) > + return -EPROBE_DEFER; > + > + smidata = devm_kzalloc(dev, sizeof(*smidata), GFP_KERNEL); > + if (!smidata) > + return -ENOMEM; > + > + smidata->clk_apb = devm_clk_get(dev, "apb"); > + if (IS_ERR(smidata->clk_apb)) > + return PTR_ERR(smidata->clk_apb); > + > + smidata->clk_smi = devm_clk_get(dev, "smi"); > + if (IS_ERR(smidata->clk_smi)) > + return PTR_ERR(smidata->clk_smi); > + > + pm_runtime_enable(dev); > + dev_set_drvdata(dev, smidata); > + return ret; ret is used uninitialised here, but you might as well just "return 0;" and get rid of the variable entirely. > +} Robin. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: robin.murphy@arm.com (Robin Murphy) Date: Tue, 27 Oct 2015 13:24:34 +0000 Subject: [PATCH v5 4/6] memory: mediatek: Add SMI driver In-Reply-To: <1444357388-30257-5-git-send-email-yong.wu@mediatek.com> References: <1444357388-30257-1-git-send-email-yong.wu@mediatek.com> <1444357388-30257-5-git-send-email-yong.wu@mediatek.com> Message-ID: <562F7B12.7030201@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/10/15 03:23, Yong Wu wrote: [...] > +static int mtk_smi_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct mtk_smi_data *smidata; > + int ret; > + > + if (!dev->pm_domain) > + return -EPROBE_DEFER; > + > + smidata = devm_kzalloc(dev, sizeof(*smidata), GFP_KERNEL); > + if (!smidata) > + return -ENOMEM; > + > + smidata->clk_apb = devm_clk_get(dev, "apb"); > + if (IS_ERR(smidata->clk_apb)) > + return PTR_ERR(smidata->clk_apb); > + > + smidata->clk_smi = devm_clk_get(dev, "smi"); > + if (IS_ERR(smidata->clk_smi)) > + return PTR_ERR(smidata->clk_smi); > + > + pm_runtime_enable(dev); > + dev_set_drvdata(dev, smidata); > + return ret; ret is used uninitialised here, but you might as well just "return 0;" and get rid of the variable entirely. > +} Robin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932430AbbJ0NYk (ORCPT ); Tue, 27 Oct 2015 09:24:40 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([146.101.78.143]:30521 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932248AbbJ0NYi convert rfc822-to-8bit (ORCPT ); Tue, 27 Oct 2015 09:24:38 -0400 From: Robin Murphy Subject: Re: [PATCH v5 4/6] memory: mediatek: Add SMI driver To: Yong Wu , Joerg Roedel , Thierry Reding , Mark Rutland , Matthias Brugger References: <1444357388-30257-1-git-send-email-yong.wu@mediatek.com> <1444357388-30257-5-git-send-email-yong.wu@mediatek.com> Cc: Will Deacon , Daniel Kurtz , Tomasz Figa , Lucas Stach , Rob Herring , Catalin Marinas , linux-mediatek@lists.infradead.org, Sasha Hauer , srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, pebolle@tiscali.nl, arnd@arndb.de, mitchelh@codeaurora.org, Sricharan R , youhua.li@mediatek.com, k.zhang@mediatek.com, kendrick.hsu@mediatek.com Message-ID: <562F7B12.7030201@arm.com> Date: Tue, 27 Oct 2015 13:24:34 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1444357388-30257-5-git-send-email-yong.wu@mediatek.com> X-OriginalArrivalTime: 27 Oct 2015 13:24:34.0784 (UTC) FILETIME=[D2403600:01D110BA] X-MC-Unique: xLxtquQ5QbmzexU9XamSSQ-1 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/10/15 03:23, Yong Wu wrote: [...] > +static int mtk_smi_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct mtk_smi_data *smidata; > + int ret; > + > + if (!dev->pm_domain) > + return -EPROBE_DEFER; > + > + smidata = devm_kzalloc(dev, sizeof(*smidata), GFP_KERNEL); > + if (!smidata) > + return -ENOMEM; > + > + smidata->clk_apb = devm_clk_get(dev, "apb"); > + if (IS_ERR(smidata->clk_apb)) > + return PTR_ERR(smidata->clk_apb); > + > + smidata->clk_smi = devm_clk_get(dev, "smi"); > + if (IS_ERR(smidata->clk_smi)) > + return PTR_ERR(smidata->clk_smi); > + > + pm_runtime_enable(dev); > + dev_set_drvdata(dev, smidata); > + return ret; ret is used uninitialised here, but you might as well just "return 0;" and get rid of the variable entirely. > +} Robin.