From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grygorii Strashko Subject: Re: [PATCH v2] spi: Setup the master controller driver before setting the chipselect Date: Tue, 27 Oct 2015 15:34:04 +0200 Message-ID: <562F7D4C.4080005@ti.com> References: <1445009343-28307-1-git-send-email-fcooper@ti.com> <56211C0F.4090102@ti.com> <562F6C9B.6010607@ti.com> <562F7801.3090508@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , , Mark Brown , Sekhar Nori , , "Ivan T. Ivanov" , , "Ivan T. Ivanov" , Jarkko Nikula , , Ivan Khoronzhuk To: "Franklin S Cooper Jr." , Andy Shevchenko Return-path: In-Reply-To: <562F7801.3090508-l0cyMroinI0@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On 10/27/2015 03:11 PM, Grygorii Strashko wrote: > On 10/27/2015 02:22 PM, Franklin S Cooper Jr. wrote: >> >> >> On 10/16/2015 10:55 AM, Andy Shevchenko wrote: >>> On Fri, Oct 16, 2015 at 6:47 PM, Franklin S Cooper Jr. >>> wrote: >>>> >>>> On 10/16/2015 10:45 AM, Andy Shevchenko wrote: >>>>> On Fri, Oct 16, 2015 at 6:29 PM, Franklin S Cooper Jr >>>>> wrote: >>>>>> SPI controllers may need to be properly setup before chip selects >>>>>> can be used. Therefore, wait until the spi controller has a chance >>>>>> to perform their setup procedure before trying to use the chip >>>>>> select. >>>>>> >>>>>> This also insures that the chip selects pins are in a good >>>>>> state before asseting them which otherwise may cause confusion. >>>>>> >>>>>> Signed-off-by: Franklin S Cooper Jr >>>>> Does it mean I have to test it again? >>>> Oops sorry. No the patch hasn't changed. I can shoot a v3 with your >>>> tested by included. >>> Whatever Mark prefers. >> Hi Mark, >> I don't see that you pulled this patch into your topic/core branch >> just yet. Would you prefer >> for me to shoot a v3 with Andy's tested by or will you just add it >> when your ready to >> pull it in? >> >> Without this patch several of our boards don't boot in linux-next so >> if there is anything you >> need for me to do please let me know. >>> >>> >> > > Boot tested on K2HK: > > Tested-by: Grygorii Strashko > Tested-by: Ivan Khoronzhuk > Sry, Fix Ivan's e-mail Tested-by: Ivan Khoronzhuk -- regards, -grygorii -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932426AbbJ0NeP (ORCPT ); Tue, 27 Oct 2015 09:34:15 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:55471 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932072AbbJ0NeO (ORCPT ); Tue, 27 Oct 2015 09:34:14 -0400 Subject: Re: [PATCH v2] spi: Setup the master controller driver before setting the chipselect To: "Franklin S Cooper Jr." , Andy Shevchenko References: <1445009343-28307-1-git-send-email-fcooper@ti.com> <56211C0F.4090102@ti.com> <562F6C9B.6010607@ti.com> <562F7801.3090508@ti.com> CC: "linux-kernel@vger.kernel.org" , , Mark Brown , Sekhar Nori , , "Ivan T. Ivanov" , , "Ivan T. Ivanov" , Jarkko Nikula , , Ivan Khoronzhuk From: Grygorii Strashko Message-ID: <562F7D4C.4080005@ti.com> Date: Tue, 27 Oct 2015 15:34:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <562F7801.3090508@ti.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/27/2015 03:11 PM, Grygorii Strashko wrote: > On 10/27/2015 02:22 PM, Franklin S Cooper Jr. wrote: >> >> >> On 10/16/2015 10:55 AM, Andy Shevchenko wrote: >>> On Fri, Oct 16, 2015 at 6:47 PM, Franklin S Cooper Jr. >>> wrote: >>>> >>>> On 10/16/2015 10:45 AM, Andy Shevchenko wrote: >>>>> On Fri, Oct 16, 2015 at 6:29 PM, Franklin S Cooper Jr >>>>> wrote: >>>>>> SPI controllers may need to be properly setup before chip selects >>>>>> can be used. Therefore, wait until the spi controller has a chance >>>>>> to perform their setup procedure before trying to use the chip >>>>>> select. >>>>>> >>>>>> This also insures that the chip selects pins are in a good >>>>>> state before asseting them which otherwise may cause confusion. >>>>>> >>>>>> Signed-off-by: Franklin S Cooper Jr >>>>> Does it mean I have to test it again? >>>> Oops sorry. No the patch hasn't changed. I can shoot a v3 with your >>>> tested by included. >>> Whatever Mark prefers. >> Hi Mark, >> I don't see that you pulled this patch into your topic/core branch >> just yet. Would you prefer >> for me to shoot a v3 with Andy's tested by or will you just add it >> when your ready to >> pull it in? >> >> Without this patch several of our boards don't boot in linux-next so >> if there is anything you >> need for me to do please let me know. >>> >>> >> > > Boot tested on K2HK: > > Tested-by: Grygorii Strashko > Tested-by: Ivan Khoronzhuk > Sry, Fix Ivan's e-mail Tested-by: Ivan Khoronzhuk -- regards, -grygorii