From: Neil Armstrong <narmstrong@baylibre.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Cc: Andrew Lunn <andrew@lunn.ch>, Guenter Roeck <linux@roeck-us.net>,
vivien.didelot@savoirfairelinux.com,
Fabian Frederick <fabf@skynet.be>,
Pavel Nakonechny <pavel.nakonechny@skitlab.ru>,
Joe Perches <joe@perches.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Frode Isaksen <fisaksen@baylibre.com>
Subject: Re: [PATCH 2/6] net: dsa: allow switch drivers to cleanup their resources
Date: Tue, 27 Oct 2015 16:43:45 +0100 [thread overview]
Message-ID: <562F9BB1.8090700@baylibre.com> (raw)
In-Reply-To: <562F9AAB.8090202@gmail.com>
Hi,
On 10/27/2015 04:39 PM, Florian Fainelli wrote:
> On 27/10/15 07:48, Neil Armstrong wrote:
>> Some switch drivers might request interrupts, remap register ranges,
>> allow such drivers to implement a "remove" callback doing just that.
>>
>> Suggested-by: Florian Fainelli <f.fainelli@gmail.com>
>
> This should probably be a Signed-off-by tag, but there is nothing using
> this, so you would want to introduce an user of this function in the
> same patch series so we see how you intend to use it?
>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Yes, I didn't know how to handle this since it was part of a larger patch.
I forgot to add this into the cover-letter but I wanted to send an RFC serie with
your bcm remove patch and a mv88e6xxx remove experimental code.
Yet, the mv88e6060 does not make usage of this.
Neil
next prev parent reply other threads:[~2015-10-27 15:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 14:48 [PATCH 2/6] net: dsa: allow switch drivers to cleanup their resources Neil Armstrong
2015-10-27 15:39 ` Florian Fainelli
2015-10-27 15:43 ` Neil Armstrong [this message]
2015-10-27 16:59 ` Vivien Didelot
2015-10-28 13:56 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562F9BB1.8090700@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=fabf@skynet.be \
--cc=fisaksen@baylibre.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=pavel.nakonechny@skitlab.ru \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.