From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 0/6] Remove some usage of shadow variable Date: Tue, 27 Oct 2015 16:12:46 +0000 Message-ID: <562FA27E.1030906@citrix.com> References: <1445960359-17217-1-git-send-email-julien.grall@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr6s3-00079z-0C for xen-devel@lists.xenproject.org; Tue, 27 Oct 2015 16:13:11 +0000 In-Reply-To: <1445960359-17217-1-git-send-email-julien.grall@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , xen-devel@lists.xenproject.org Cc: Keir Fraser , Ian Campbell , George Dunlap , Dario Faggioli , Tim Deegan , Stefano Stabellini , Jan Beulich List-Id: xen-devel@lists.xenproject.org On 27/10/15 15:39, Julien Grall wrote: > Hi all, > > I wrote this patch series after noticing that one of my series [1] was > shadowing a variable and GCC didn't warn it. > > So I've turned on -Wshadow and look at if there is other places abusing > of shadow variable in Xen. > > This series is not complete and only contain the more simple changes. > > I'd like to have some input to know whether turning on -Wshadow would be > sensible in the future. > > Regards, All 6 patches Reviewed-by: Andrew Cooper As for the -Wshadow default, that is more problematic. There are several quite buggy verisons of GCC wrt shadowing, so I don't think it is sensible to enable unilaterally. ~Andrew