From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 4/6] xen/common: memory: Avoid to shadow the variable "d" in do_memory_op Date: Tue, 27 Oct 2015 16:51:00 +0000 Message-ID: <562FAB74.2080602@citrix.com> References: <1445960359-17217-1-git-send-email-julien.grall@citrix.com> <1445960359-17217-5-git-send-email-julien.grall@citrix.com> <562FB38D02000078000AF460@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr7Uj-0001kF-4k for xen-devel@lists.xenproject.org; Tue, 27 Oct 2015 16:53:09 +0000 In-Reply-To: <562FB38D02000078000AF460@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel@lists.xenproject.org, Keir Fraser , Ian Campbell , Tim Deegan List-Id: xen-devel@lists.xenproject.org On 27/10/15 16:25, Jan Beulich wrote: >>>> On 27.10.15 at 16:39, wrote: >> The variable "d" is declared multiple times within do_memory_op. >> >> The subsequent declaration are not useful because the top one is never >> used. So drop them. > > The patch is correct, but the description is slightly off: The top one > is used in other case blocks. (I should have said this on the other > one too: No reason to re-submit.) Right, I wasn't sure how to describe it correctly. Regards, -- Julien Grall