All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Hurley <peter@hurleysoftware.com>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH 04/15] serial/fsl_lpuart: Deinline lpuart_transmit_buffer, save 176 bytes
Date: Tue, 27 Oct 2015 14:24:13 -0400	[thread overview]
Message-ID: <562FC14D.6060404@hurleysoftware.com> (raw)
In-Reply-To: <1445968007-12616-5-git-send-email-dvlasenk@redhat.com>

On 10/27/2015 01:46 PM, Denys Vlasenko wrote:
> This function compiles to 172 bytes of machine code.
> 
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CC: Peter Hurley <peter@hurleysoftware.com>
> CC: Jiri Slaby <jslaby@suse.com>
> CC: linux-serial@vger.kernel.org
> ---
>  drivers/tty/serial/fsl_lpuart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
> index 08ce76f..ac26303 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -527,7 +527,7 @@ static inline void lpuart_prepare_rx(struct lpuart_port *sport)
>  	spin_unlock_irqrestore(&sport->port.lock, flags);
>  }
>  
> -static inline void lpuart_transmit_buffer(struct lpuart_port *sport)
> +static void lpuart_transmit_buffer(struct lpuart_port *sport)
>  {
>  	struct circ_buf *xmit = &sport->port.state->xmit;

You'll want to run your script(s) on Greg's tty-next tree;
this file has copy+paste changes for 4.4 that added
lpuart32_transmit_buffer() as an inline function.

Regards,
Peter Hurley

  reply	other threads:[~2015-10-27 18:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27 17:46 [PATCH 00/15] drivers/tty/: Deinline smaller/less used functions Denys Vlasenko
2015-10-27 17:46 ` [PATCH 01/15] cyclades: Deinline cyz_is_loaded, save 240 bytes Denys Vlasenko
2015-10-27 18:18   ` Peter Hurley
2015-10-27 17:46 ` [PATCH 02/15] isicom: Deinline drop_dtr, save 112 bytes Denys Vlasenko
2015-10-27 18:19   ` Peter Hurley
2015-10-27 17:46 ` [PATCH 03/15] tty: Deinline n_tty_receive_char_inline, save 224 bytes Denys Vlasenko
2015-10-27 18:08   ` Peter Hurley
2015-10-27 17:46 ` [PATCH 04/15] serial/fsl_lpuart: Deinline lpuart_transmit_buffer, save 176 bytes Denys Vlasenko
2015-10-27 18:24   ` Peter Hurley [this message]
2015-10-27 17:46 ` [PATCH 05/15] serial/m32r_sio: Deinline wait_for_xmitr, save 165 bytes Denys Vlasenko
2015-10-27 18:25   ` Peter Hurley
2015-10-27 17:46 ` [PATCH 06/15] serial/men_z135_uart: Deinline men_z135_reg_clr, save 176 bytes Denys Vlasenko
2015-10-27 18:55   ` Peter Hurley
2015-10-27 17:46 ` [PATCH 07/15] serial/msm_serial: Deinline wait_for_xmitr, save 165 bytes Denys Vlasenko
2015-10-27 18:30   ` Peter Hurley
2015-10-27 17:46 ` [PATCH 08/15] serial/omap-serial: " Denys Vlasenko
2015-10-27 18:31   ` Peter Hurley
2015-10-27 17:46 ` [PATCH 09/15] serial/pxa: " Denys Vlasenko
2015-10-27 18:32   ` Peter Hurley
2015-10-27 18:14 ` [PATCH 00/15] drivers/tty/: Deinline smaller/less used functions Peter Hurley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562FC14D.6060404@hurleysoftware.com \
    --to=peter@hurleysoftware.com \
    --cc=dvlasenk@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.