From: "René Scharfe" <l.s.r@web.de>
To: Stefan Beller <sbeller@google.com>, Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>, Jeff King <peff@peff.net>
Subject: Re: [PATCH 1/2] run-command: factor out child_process_clear()
Date: Tue, 27 Oct 2015 22:29:46 +0100 [thread overview]
Message-ID: <562FECCA.6080703@web.de> (raw)
In-Reply-To: <CAGZ79kYopHL5D_7+bJV2P9GeKDHufPDBTo3a8bRL=4B3OmTGjg@mail.gmail.com>
Am 26.10.2015 um 20:23 schrieb Stefan Beller:
> On Mon, Oct 26, 2015 at 11:43 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> René Scharfe <l.s.r@web.de> writes:
>>
>>> Avoid duplication by moving the code to release allocated memory for
>>> arguments and environment to its own function, child_process_clear().
>>> Export it to provide a counterpart to child_process_init().
>>>
>>> Signed-off-by: Rene Scharfe <l.s.r@web.de>
>>> ---
>>
>> Hmm, is this _deinit() Stefan added to his series recently?
>
> Yes. Although you (Junio) take credit for actually using it in these
> places, too. :)
Oh, and it's already in next. I still like _clear() better (as in
{argv,object,ref,sha1}_array_clear(), or string_list_clear(), or ...)
than _deinit(), which seems to have been introduced by vcs-svn and isn't
a real word. I'll rebase my patches on top of this series, but probably
not before the weekend.
René
next prev parent reply other threads:[~2015-10-27 21:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-24 12:11 [PATCH 1/2] run-command: factor out child_process_clear() René Scharfe
2015-10-24 12:23 ` [PATCH 2/2] daemon: plug memory leak René Scharfe
2015-10-26 19:47 ` Jeff King
2015-10-26 18:43 ` [PATCH 1/2] run-command: factor out child_process_clear() Junio C Hamano
2015-10-26 19:23 ` Stefan Beller
2015-10-27 21:29 ` René Scharfe [this message]
2015-10-27 21:31 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562FECCA.6080703@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.