From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: isp1760-hcd: Fix fall-through annotations From: "Gustavo A. R. Silva" Message-Id: <562edc29-07ff-eaf5-5239-a30cd0add70c@embeddedor.com> Date: Wed, 1 May 2019 11:13:44 -0500 To: Greg Kroah-Hartman Cc: Arvid Brodin , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gNS8xLzE5IDExOjAzIEFNLCBHcmVnIEtyb2FoLUhhcnRtYW4gd3JvdGU6Cj4gT24gV2VkLCBN YXkgMDEsIDIwMTkgYXQgMTA6Mzk6MzRBTSAtMDUwMCwgR3VzdGF2byBBLiBSLiBTaWx2YSB3cm90 ZToKPj4gSW4gcHJlcGFyYXRpb24gdG8gZW5hYmxpbmcgLVdpbXBsaWNpdC1mYWxsdGhyb3VnaCwg bWFyayBzd2l0Y2gKPj4gY2FzZXMgd2hlcmUgd2UgYXJlIGV4cGVjdGluZyB0byBmYWxsIHRocm91 Z2guCj4+Cj4+IFRoaXMgcGF0Y2ggZml4ZXMgdGhlIGZvbGxvd2luZyB3YXJuaW5nOgo+Pgo+PiBk cml2ZXJzL3VzYi9pc3AxNzYwL2lzcDE3NjAtaGNkLmM6IEluIGZ1bmN0aW9uIOKAmGNvbGxlY3Rf cXRkc+KAmToKPj4gZHJpdmVycy91c2IvaXNwMTc2MC9pc3AxNzYwLWhjZC5jOjc4ODo2OiB3YXJu aW5nOiB0aGlzIHN0YXRlbWVudCBtYXkgZmFsbCB0aHJvdWdoIFstV2ltcGxpY2l0LWZhbGx0aHJv dWdoPV0KPj4gICAgICAgbWVtX3JlYWRzOChoY2QtPnJlZ3MsIHF0ZC0+cGF5bG9hZF9hZGRyLAo+ PiAgICAgICBefn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+Cj4+ICAgICAg ICAgcXRkLT5kYXRhX2J1ZmZlciwKPj4gICAgICAgICB+fn5+fn5+fn5+fn5+fn5+fgo+PiAgICAg ICAgIHF0ZC0+YWN0dWFsX2xlbmd0aCk7Cj4+ICAgICAgICAgfn5+fn5+fn5+fn5+fn5+fn5+fgo+ PiBkcml2ZXJzL3VzYi9pc3AxNzYwL2lzcDE3NjAtaGNkLmM6NzkyOjU6IG5vdGU6IGhlcmUKPj4g ICAgICBjYXNlIE9VVF9QSUQ6Cj4+ICAgICAgXn5+fgo+Pgo+PiBXYXJuaW5nIGxldmVsIDMgd2Fz IHVzZWQ6IC1XaW1wbGljaXQtZmFsbHRocm91Z2g9Mwo+Pgo+PiBOb3RpY2UgdGhhdCwgaW4gdGhp cyBwYXJ0aWN1bGFyIGNhc2UsIHRoZSBjb2RlIGNvbW1lbnRzIGFyZSBtb2RpZmllZAo+PiBpbiBh Y2NvcmRhbmNlIHdpdGggd2hhdCBHQ0MgaXMgZXhwZWN0aW5nIHRvIGZpbmQuCj4+Cj4+IFRoaXMg cGF0Y2ggaXMgcGFydCBvZiB0aGUgb25nb2luZyBlZmZvcnRzIHRvIGVuYWJsZQo+PiAtV2ltcGxp Y2l0LWZhbGx0aHJvdWdoLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBHdXN0YXZvIEEuIFIuIFNpbHZh IDxndXN0YXZvQGVtYmVkZGVkb3IuY29tPgo+PiAtLS0KPj4gTm90aWNlIHRoYXQgdGhpcyBjb2Rl IGhhcyBiZWVuIG91dCB0aGVyZSBzaW5jZSAyMDExLCBhbmQgd2hvCj4+IGludHJvZHVjZWQgdGhl IHF1ZXN0aW9uIG1hcmsgd2FzIHRoZSBvcmlnaW5hbCBkZXZlbG9wZXIuCj4+Cj4+IEl0J2QgYmUg Z29vZCBpZiBzb21lb25lIGNhbiBjb25maXJtIHRoYXQgdGhlIGZhbGwtdGhyb3VnaAo+PiBoYXMg YmVlbiBpbnRlbnRpb25hbCBhbGwgdGhpcyB0aW1lLgo+IAo+IFllcywgaXQgbG9va3MgaW50ZW50 aW9uYWwuICBNZXNzeSwgYW5kIGFzIG5vIG9uZSBoYXMgY29tcGxhaW5lZCBzaW5jZQo+IDIwMTEs IGxldCdzIGxlYXZlIGl0IGFsb25lLCBJJ2xsIHF1ZXVlIHRoaXMgdXAuCj4gCgpHcmVhdC4KClRo YW5rcywgR3JlZy4KLS0tCkd1c3Rhdm8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2246EC43219 for ; Wed, 1 May 2019 16:13:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF3A1208C3 for ; Wed, 1 May 2019 16:13:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726561AbfEAQNu (ORCPT ); Wed, 1 May 2019 12:13:50 -0400 Received: from gateway31.websitewelcome.com ([192.185.144.94]:27031 "EHLO gateway31.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726554AbfEAQNt (ORCPT ); Wed, 1 May 2019 12:13:49 -0400 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 9EB9623F1C for ; Wed, 1 May 2019 11:13:48 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id LrrghCT3K4FKpLrrghczpL; Wed, 01 May 2019 11:13:48 -0500 X-Authority-Reason: nr=8 Received: from [189.250.119.203] (port=32916 helo=[192.168.1.76]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1hLrrf-001oEy-PH; Wed, 01 May 2019 11:13:48 -0500 Subject: Re: [PATCH] usb: isp1760-hcd: Fix fall-through annotations To: Greg Kroah-Hartman Cc: Arvid Brodin , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190501153934.GA20025@embeddedor> <20190501160327.GA19281@kroah.com> From: "Gustavo A. R. Silva" Openpgp: preference=signencrypt Autocrypt: addr=gustavo@embeddedor.com; keydata= mQINBFssHAwBEADIy3ZoPq3z5UpsUknd2v+IQud4TMJnJLTeXgTf4biSDSrXn73JQgsISBwG 2Pm4wnOyEgYUyJd5tRWcIbsURAgei918mck3tugT7AQiTUN3/5aAzqe/4ApDUC+uWNkpNnSV tjOx1hBpla0ifywy4bvFobwSh5/I3qohxDx+c1obd8Bp/B/iaOtnq0inli/8rlvKO9hp6Z4e DXL3PlD0QsLSc27AkwzLEc/D3ZaqBq7ItvT9Pyg0z3Q+2dtLF00f9+663HVC2EUgP25J3xDd 496SIeYDTkEgbJ7WYR0HYm9uirSET3lDqOVh1xPqoy+U9zTtuA9NQHVGk+hPcoazSqEtLGBk YE2mm2wzX5q2uoyptseSNceJ+HE9L+z1KlWW63HhddgtRGhbP8pj42bKaUSrrfDUsicfeJf6 m1iJRu0SXYVlMruGUB1PvZQ3O7TsVfAGCv85pFipdgk8KQnlRFkYhUjLft0u7CL1rDGZWDDr NaNj54q2CX9zuSxBn9XDXvGKyzKEZ4NY1Jfw+TAMPCp4buawuOsjONi2X0DfivFY+ZsjAIcx qQMglPtKk/wBs7q2lvJ+pHpgvLhLZyGqzAvKM1sVtRJ5j+ARKA0w4pYs5a5ufqcfT7dN6TBk LXZeD9xlVic93Ju08JSUx2ozlcfxq+BVNyA+dtv7elXUZ2DrYwARAQABtCxHdXN0YXZvIEEu IFIuIFNpbHZhIDxndXN0YXZvQGVtYmVkZGVkb3IuY29tPokCPQQTAQgAJwUCWywcDAIbIwUJ CWYBgAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRBHBbTLRwbbMZ6tEACk0hmmZ2FWL1Xi l/bPqDGFhzzexrdkXSfTTZjBV3a+4hIOe+jl6Rci/CvRicNW4H9yJHKBrqwwWm9fvKqOBAg9 obq753jydVmLwlXO7xjcfyfcMWyx9QdYLERTeQfDAfRqxir3xMeOiZwgQ6dzX3JjOXs6jHBP cgry90aWbaMpQRRhaAKeAS14EEe9TSIly5JepaHoVdASuxklvOC0VB0OwNblVSR2S5i5hSsh ewbOJtwSlonsYEj4EW1noQNSxnN/vKuvUNegMe+LTtnbbocFQ7dGMsT3kbYNIyIsp42B5eCu JXnyKLih7rSGBtPgJ540CjoPBkw2mCfhj2p5fElRJn1tcX2McsjzLFY5jK9RYFDavez5w3lx JFgFkla6sQHcrxH62gTkb9sUtNfXKucAfjjCMJ0iuQIHRbMYCa9v2YEymc0k0RvYr43GkA3N PJYd/vf9vU7VtZXaY4a/dz1d9dwIpyQARFQpSyvt++R74S78eY/+lX8wEznQdmRQ27kq7BJS R20KI/8knhUNUJR3epJu2YFT/JwHbRYC4BoIqWl+uNvDf+lUlI/D1wP+lCBSGr2LTkQRoU8U 64iK28BmjJh2K3WHmInC1hbUucWT7Swz/+6+FCuHzap/cjuzRN04Z3Fdj084oeUNpP6+b9yW e5YnLxF8ctRAp7K4yVlvA7kCDQRbLBwMARAAsHCE31Ffrm6uig1BQplxMV8WnRBiZqbbsVJB H1AAh8tq2ULl7udfQo1bsPLGGQboJSVN9rckQQNahvHAIK8ZGfU4Qj8+CER+fYPp/MDZj+t0 DbnWSOrG7z9HIZo6PR9z4JZza3Hn/35jFggaqBtuydHwwBANZ7A6DVY+W0COEU4of7CAahQo 5NwYiwS0lGisLTqks5R0Vh+QpvDVfuaF6I8LUgQR/cSgLkR//V1uCEQYzhsoiJ3zc1HSRyOP otJTApqGBq80X0aCVj1LOiOF4rrdvQnj6iIlXQssdb+WhSYHeuJj1wD0ZlC7ds5zovXh+FfF l5qH5RFY/qVn3mNIVxeO987WSF0jh+T5ZlvUNdhedGndRmwFTxq2Li6GNMaolgnpO/CPcFpD jKxY/HBUSmaE9rNdAa1fCd4RsKLlhXda+IWpJZMHlmIKY8dlUybP+2qDzP2lY7kdFgPZRU+e zS/pzC/YTzAvCWM3tDgwoSl17vnZCr8wn2/1rKkcLvTDgiJLPCevqpTb6KFtZosQ02EGMuHQ I6Zk91jbx96nrdsSdBLGH3hbvLvjZm3C+fNlVb9uvWbdznObqcJxSH3SGOZ7kCHuVmXUcqoz ol6ioMHMb+InrHPP16aVDTBTPEGwgxXI38f7SUEn+NpbizWdLNz2hc907DvoPm6HEGCanpcA EQEAAYkCJQQYAQgADwUCWywcDAIbDAUJCWYBgAAKCRBHBbTLRwbbMdsZEACUjmsJx2CAY+QS UMebQRFjKavwXB/xE7fTt2ahuhHT8qQ/lWuRQedg4baInw9nhoPE+VenOzhGeGlsJ0Ys52sd XvUjUocKgUQq6ekOHbcw919nO5L9J2ejMf/VC/quN3r3xijgRtmuuwZjmmi8ct24TpGeoBK4 WrZGh/1hAYw4ieARvKvgjXRstcEqM5thUNkOOIheud/VpY+48QcccPKbngy//zNJWKbRbeVn imua0OpqRXhCrEVm/xomeOvl1WK1BVO7z8DjSdEBGzbV76sPDJb/fw+y+VWrkEiddD/9CSfg fBNOb1p1jVnT2mFgGneIWbU0zdDGhleI9UoQTr0e0b/7TU+Jo6TqwosP9nbk5hXw6uR5k5PF 8ieyHVq3qatJ9K1jPkBr8YWtI5uNwJJjTKIA1jHlj8McROroxMdI6qZ/wZ1ImuylpJuJwCDC ORYf5kW61fcrHEDlIvGc371OOvw6ejF8ksX5+L2zwh43l/pKkSVGFpxtMV6d6J3eqwTafL86 YJWH93PN+ZUh6i6Rd2U/i8jH5WvzR57UeWxE4P8bQc0hNGrUsHQH6bpHV2lbuhDdqo+cM9eh GZEO3+gCDFmKrjspZjkJbB5Gadzvts5fcWGOXEvuT8uQSvl+vEL0g6vczsyPBtqoBLa9SNrS VtSixD1uOgytAP7RWS474w== Message-ID: <562edc29-07ff-eaf5-5239-a30cd0add70c@embeddedor.com> Date: Wed, 1 May 2019 11:13:44 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190501160327.GA19281@kroah.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.119.203 X-Source-L: No X-Exim-ID: 1hLrrf-001oEy-PH X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.76]) [189.250.119.203]:32916 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 3 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190501161344.gLCDNB7iarreVLUXSs1K9hv-BeKg44rAJlOiYolfFG8@z> On 5/1/19 11:03 AM, Greg Kroah-Hartman wrote: > On Wed, May 01, 2019 at 10:39:34AM -0500, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch >> cases where we are expecting to fall through. >> >> This patch fixes the following warning: >> >> drivers/usb/isp1760/isp1760-hcd.c: In function ‘collect_qtds’: >> drivers/usb/isp1760/isp1760-hcd.c:788:6: warning: this statement may fall through [-Wimplicit-fallthrough=] >> mem_reads8(hcd->regs, qtd->payload_addr, >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> qtd->data_buffer, >> ~~~~~~~~~~~~~~~~~ >> qtd->actual_length); >> ~~~~~~~~~~~~~~~~~~~ >> drivers/usb/isp1760/isp1760-hcd.c:792:5: note: here >> case OUT_PID: >> ^~~~ >> >> Warning level 3 was used: -Wimplicit-fallthrough=3 >> >> Notice that, in this particular case, the code comments are modified >> in accordance with what GCC is expecting to find. >> >> This patch is part of the ongoing efforts to enable >> -Wimplicit-fallthrough. >> >> Signed-off-by: Gustavo A. R. Silva >> --- >> Notice that this code has been out there since 2011, and who >> introduced the question mark was the original developer. >> >> It'd be good if someone can confirm that the fall-through >> has been intentional all this time. > > Yes, it looks intentional. Messy, and as no one has complained since > 2011, let's leave it alone, I'll queue this up. > Great. Thanks, Greg. -- Gustavo