From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v3 4/5] clk: s2mps15: Add support for S2MPS15 clocks To: Alim Akhtar , lee.jones@linaro.org, broonie@kernel.org References: <1445863883-5187-1-git-send-email-alim.akhtar@samsung.com> <1445863883-5187-5-git-send-email-alim.akhtar@samsung.com> Cc: mturquette@baylibre.com, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-id: <5630234A.8080905@samsung.com> Date: Wed, 28 Oct 2015 10:22:18 +0900 MIME-version: 1.0 In-reply-to: <1445863883-5187-5-git-send-email-alim.akhtar@samsung.com> Content-type: text/plain; charset=windows-1252 List-ID: On 26.10.2015 21:51, Alim Akhtar wrote: > S2MPS15 PMIC has three 32k buffered clocks outputs. This patch > adds supports for the same to the s2mps11 clock driver. > > Signed-off-by: Alim Akhtar > --- > drivers/clk/Kconfig | 5 +++-- > drivers/clk/clk-s2mps11.c | 24 ++++++++++++++++++++++++ > 2 files changed, 27 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index a1fa61159179..037a314b5d76 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -120,9 +120,10 @@ config COMMON_CLK_S2MPS11 > tristate "Clock driver for S2MPS1X/S5M8767 MFD" > depends on MFD_SEC_CORE > ---help--- > - This driver supports S2MPS11/S2MPS14/S5M8767 crystal oscillator > + This driver supports S2MPS1X/S5M8767 crystal oscillator > clock. These multi-function devices have two (S2MPS14) or three > - (S2MPS11, S5M8767) fixed-rate oscillators, clocked at 32KHz each. > + (S2MPS11/S2MPS13/S2MPS15/S5M8767) fixed-rate oscillators, > + clocked at 32KHz each. > > config CLK_TWL6040 > tristate "External McPDM functional clock from twl6040" > diff --git a/drivers/clk/clk-s2mps11.c b/drivers/clk/clk-s2mps11.c > index d266299dfdb1..455500dca653 100644 > --- a/drivers/clk/clk-s2mps11.c > +++ b/drivers/clk/clk-s2mps11.c > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -148,6 +149,24 @@ static struct clk_init_data s2mps14_clks_init[S2MPS11_CLKS_NUM] = { > }, > }; > > +static struct clk_init_data s2mps15_clks_init[S2MPS11_CLKS_NUM] = { > + [S2MPS11_CLK_AP] = { > + .name = "s2mps15_ap", > + .ops = &s2mps11_clk_ops, > + .flags = CLK_IS_ROOT, > + }, > + [S2MPS11_CLK_CP] = { > + .name = "s2mps15_cp", > + .ops = &s2mps11_clk_ops, > + .flags = CLK_IS_ROOT, > + }, > + [S2MPS11_CLK_BT] = { > + .name = "s2mps15_bt", > + .ops = &s2mps11_clk_ops, > + .flags = CLK_IS_ROOT, > + }, > +}; I see that for S2MPS13 we already added similar array which duplicates the S2MPS11. This actually looks wrong. Just re-use existing s2mps11_clks_init. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com. [210.118.77.11]) by gmr-mx.google.com with ESMTPS id zg1si4649358pbb.2.2015.10.27.18.22.33 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 27 Oct 2015 18:22:33 -0700 (PDT) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NWW000GYP5H5700@mailout1.w1.samsung.com> for rtc-linux@googlegroups.com; Wed, 28 Oct 2015 01:22:29 +0000 (GMT) Subject: [rtc-linux] Re: [PATCH v3 4/5] clk: s2mps15: Add support for S2MPS15 clocks To: Alim Akhtar , lee.jones@linaro.org, broonie@kernel.org References: <1445863883-5187-1-git-send-email-alim.akhtar@samsung.com> <1445863883-5187-5-git-send-email-alim.akhtar@samsung.com> Cc: mturquette@baylibre.com, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-id: <5630234A.8080905@samsung.com> Date: Wed, 28 Oct 2015 10:22:18 +0900 MIME-version: 1.0 In-reply-to: <1445863883-5187-5-git-send-email-alim.akhtar@samsung.com> Content-type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 26.10.2015 21:51, Alim Akhtar wrote: > S2MPS15 PMIC has three 32k buffered clocks outputs. This patch > adds supports for the same to the s2mps11 clock driver. > > Signed-off-by: Alim Akhtar > --- > drivers/clk/Kconfig | 5 +++-- > drivers/clk/clk-s2mps11.c | 24 ++++++++++++++++++++++++ > 2 files changed, 27 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index a1fa61159179..037a314b5d76 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -120,9 +120,10 @@ config COMMON_CLK_S2MPS11 > tristate "Clock driver for S2MPS1X/S5M8767 MFD" > depends on MFD_SEC_CORE > ---help--- > - This driver supports S2MPS11/S2MPS14/S5M8767 crystal oscillator > + This driver supports S2MPS1X/S5M8767 crystal oscillator > clock. These multi-function devices have two (S2MPS14) or three > - (S2MPS11, S5M8767) fixed-rate oscillators, clocked at 32KHz each. > + (S2MPS11/S2MPS13/S2MPS15/S5M8767) fixed-rate oscillators, > + clocked at 32KHz each. > > config CLK_TWL6040 > tristate "External McPDM functional clock from twl6040" > diff --git a/drivers/clk/clk-s2mps11.c b/drivers/clk/clk-s2mps11.c > index d266299dfdb1..455500dca653 100644 > --- a/drivers/clk/clk-s2mps11.c > +++ b/drivers/clk/clk-s2mps11.c > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -148,6 +149,24 @@ static struct clk_init_data s2mps14_clks_init[S2MPS11_CLKS_NUM] = { > }, > }; > > +static struct clk_init_data s2mps15_clks_init[S2MPS11_CLKS_NUM] = { > + [S2MPS11_CLK_AP] = { > + .name = "s2mps15_ap", > + .ops = &s2mps11_clk_ops, > + .flags = CLK_IS_ROOT, > + }, > + [S2MPS11_CLK_CP] = { > + .name = "s2mps15_cp", > + .ops = &s2mps11_clk_ops, > + .flags = CLK_IS_ROOT, > + }, > + [S2MPS11_CLK_BT] = { > + .name = "s2mps15_bt", > + .ops = &s2mps11_clk_ops, > + .flags = CLK_IS_ROOT, > + }, > +}; I see that for S2MPS13 we already added similar array which duplicates the S2MPS11. This actually looks wrong. Just re-use existing s2mps11_clks_init. Best regards, Krzysztof -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.