From mboxrd@z Thu Jan 1 00:00:00 1970 From: Weidong Wang Subject: Re: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_ Date: Wed, 28 Oct 2015 09:59:49 +0800 Message-ID: <56302C15.8000001@huawei.com> References: <1445934375-17784-1-git-send-email-wangweidong1@huawei.com> <1445934375-17784-2-git-send-email-wangweidong1@huawei.com> <1445974556.2757.47.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1445974556.2757.47.camel@perches.com> Sender: linux-kernel-owner@vger.kernel.org To: Joe Perches Cc: kashyap.desai@avagotech.com, sumit.saxena@avagotech.com, uday.lingala@avagotech.com, JBottomley@odin.com, megaraidlinux.pdl@avagotech.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On 2015/10/28 3:35, Joe Perches wrote: > On Tue, 2015-10-27 at 16:26 +0800, Weidong Wang wrote: >> Reduce object size a little by using dev_ >> calls instead of dev_printk(KERN_. > > This is also not the same output. > > dev_printk(KERN_DEBUG vs dev_dbg has the same > behavior as printk(KERN_DEBUG vs pr_debug > yep, You are right. As Kashyap said, these two patches(Covert [dev_]printk to [dev|pr]_) may introduced conflicts to their working for megaraid_sas. So just ignore these two patches. Regards, Weidong >> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c > [] >> @@ -1884,7 +1884,7 @@ static int megasas_get_ld_vf_affiliation_111(struct megasas_instance *instance, >> cmd = megasas_get_cmd(instance); >> >> if (!cmd) { >> - dev_printk(KERN_DEBUG, &instance->pdev->dev, "megasas_get_ld_vf_affiliation_111:" >> + dev_dbg(&instance->pdev->dev, "megasas_get_ld_vf_affiliation_111:" >> "Failed to get cmd for scsi%d\n", >> instance->host->host_no); >> return -ENOMEM; > [] >> @@ -5243,7 +5243,7 @@ static int megasas_probe_one(struct pci_dev *pdev, >> &instance->consumer_h); >> >> if (!instance->producer || !instance->consumer) { >> - dev_printk(KERN_DEBUG, &pdev->dev, "Failed to allocate" >> + dev_dbg(&pdev->dev, "Failed to allocate" >> "memory for producer, consumer\n"); > > Note the lack of a space between coalesced string segment words. > That's one of the reasons to coalesce them. > > > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754839AbbJ1CAD (ORCPT ); Tue, 27 Oct 2015 22:00:03 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:32314 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbbJ1CAA (ORCPT ); Tue, 27 Oct 2015 22:00:00 -0400 Message-ID: <56302C15.8000001@huawei.com> Date: Wed, 28 Oct 2015 09:59:49 +0800 From: Weidong Wang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Joe Perches CC: , , , , , , Subject: Re: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_ References: <1445934375-17784-1-git-send-email-wangweidong1@huawei.com> <1445934375-17784-2-git-send-email-wangweidong1@huawei.com> <1445974556.2757.47.camel@perches.com> In-Reply-To: <1445974556.2757.47.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.21.100] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/10/28 3:35, Joe Perches wrote: > On Tue, 2015-10-27 at 16:26 +0800, Weidong Wang wrote: >> Reduce object size a little by using dev_ >> calls instead of dev_printk(KERN_. > > This is also not the same output. > > dev_printk(KERN_DEBUG vs dev_dbg has the same > behavior as printk(KERN_DEBUG vs pr_debug > yep, You are right. As Kashyap said, these two patches(Covert [dev_]printk to [dev|pr]_) may introduced conflicts to their working for megaraid_sas. So just ignore these two patches. Regards, Weidong >> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c > [] >> @@ -1884,7 +1884,7 @@ static int megasas_get_ld_vf_affiliation_111(struct megasas_instance *instance, >> cmd = megasas_get_cmd(instance); >> >> if (!cmd) { >> - dev_printk(KERN_DEBUG, &instance->pdev->dev, "megasas_get_ld_vf_affiliation_111:" >> + dev_dbg(&instance->pdev->dev, "megasas_get_ld_vf_affiliation_111:" >> "Failed to get cmd for scsi%d\n", >> instance->host->host_no); >> return -ENOMEM; > [] >> @@ -5243,7 +5243,7 @@ static int megasas_probe_one(struct pci_dev *pdev, >> &instance->consumer_h); >> >> if (!instance->producer || !instance->consumer) { >> - dev_printk(KERN_DEBUG, &pdev->dev, "Failed to allocate" >> + dev_dbg(&pdev->dev, "Failed to allocate" >> "memory for producer, consumer\n"); > > Note the lack of a space between coalesced string segment words. > That's one of the reasons to coalesce them. > > > > . >