All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] spi: altera_spi: Minor cleanup
Date: Wed, 28 Oct 2015 15:14:56 +0800	[thread overview]
Message-ID: <563075F0.6080600@wytron.com.tw> (raw)
In-Reply-To: <1445968032-11105-2-git-send-email-jteki@openedev.com>

Hi Jagan,

On 10/28/2015 01:47 AM, Jagan Teki wrote:
> - Moved macro definitions to top
> - Give tab space to CONFIG_ALTERA_SPI_IDLE_VAL value
> - Re-arrange header includes to ascending order
>
> Cc: Thomas Chou <thomas@wytron.com.tw>
> Signed-off-by: Jagan Teki <jteki@openedev.com>
> ---
>   drivers/spi/altera_spi.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>

Acked-by: Thomas Chou <thomas@wytron.com.tw>

Thanks a lot.

Best regards,
Thomas Chou

> diff --git a/drivers/spi/altera_spi.c b/drivers/spi/altera_spi.c
> index 3dbcfaa..e49949b 100644
> --- a/drivers/spi/altera_spi.c
> +++ b/drivers/spi/altera_spi.c
> @@ -11,14 +11,17 @@
>   #include <dm.h>
>   #include <errno.h>
>   #include <malloc.h>
> -#include <spi.h>
>   #include <fdtdec.h>
> +#include <spi.h>
>   #include <asm/io.h>
>
>   DECLARE_GLOBAL_DATA_PTR;
>
> +#define ALTERA_SPI_STATUS_RRDY_MSK	BIT(7)
> +#define ALTERA_SPI_CONTROL_SSO_MSK	BIT(10)
> +
>   #ifndef CONFIG_ALTERA_SPI_IDLE_VAL
> -#define CONFIG_ALTERA_SPI_IDLE_VAL 0xff
> +#define CONFIG_ALTERA_SPI_IDLE_VAL	0xff
>   #endif
>
>   struct altera_spi_regs {
> @@ -38,9 +41,6 @@ struct altera_spi_priv {
>   	struct altera_spi_regs *regs;
>   };
>
> -#define ALTERA_SPI_STATUS_RRDY_MSK	BIT(7)
> -#define ALTERA_SPI_CONTROL_SSO_MSK	BIT(10)
> -
>   static void spi_cs_activate(struct udevice *dev, uint cs)
>   {
>   	struct udevice *bus = dev->parent;
>

  reply	other threads:[~2015-10-28  7:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27 17:47 [U-Boot] [PATCH v6 03/23] spi: altera_spi: Use BIT macro Jagan Teki
2015-10-27 17:47 ` [U-Boot] [PATCH] spi: altera_spi: Minor cleanup Jagan Teki
2015-10-28  7:14   ` Thomas Chou [this message]
2015-10-28  7:14 ` [U-Boot] [PATCH v6 03/23] spi: altera_spi: Use BIT macro Thomas Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563075F0.6080600@wytron.com.tw \
    --to=thomas@wytron.com.tw \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.