Re: [PATCH v3] clk: tango4: clkgen driver for Tango4 ARM platforms

[Marc Gonzalez <marc_gonzalez@sigmadesigns.com>]

Hello Michael & Stephen,

On 23/10/2015 17:40, Marc Gonzalez wrote:

> Add support for Sigma Designs Tango4 (ARM-based) clock generator.
> NOTE: This driver is incompatible with Tango3 clkgen.
> 
> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
> ---
> Changes in v3:
> Provide binding documentation
> Don't unconditionally use hard-coded divider for sysclk
> 
> Changes in v2:
> Provide missing includes
> Use masks instead of bit-fields
> Error handling
> Style nits
> Model the clkgen block as a single node
> ---
>  .../devicetree/bindings/clock/tango4-clock.txt     | 27 ++++++++++
>  drivers/clk/Makefile                               |  1 +
>  drivers/clk/clk-tango4.c                           | 57 ++++++++++++++++++++++
>  3 files changed, 85 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/tango4-clock.txt
>  create mode 100644 drivers/clk/clk-tango4.c

Are there any remaining issues that have not been addressed?
(A cosmetic change: should I remove the double-spacing in the
"Required Properties" list of the binding document?)

I would need to send a v4, with a minor tweak of the commit message,
as I found out that there has existed one non-ARM Tango4 SoC.
(But it's not clear whether it ever went further than eval boards.)
I would bundle that change along with any additional required fixes.

How close/far is this driver from being accepted?

Regards.