From mboxrd@z Thu Jan  1 00:00:00 1970
References: <20151028105140.GA26607@hermes.click-hack.org>
 <1446030916-6963-1-git-send-email-henning.schild@siemens.com>
From: Philippe Gerum <rpm@xenomai.org>
Message-ID: <5630B0EB.4000000@xenomai.org>
Date: Wed, 28 Oct 2015 12:26:35 +0100
MIME-Version: 1.0
In-Reply-To: <1446030916-6963-1-git-send-email-henning.schild@siemens.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Xenomai] [PATCH v4] scripts: use mktemp instead of relying on
 TMPDIR beeing in env
List-Id: Discussions about the Xenomai project <xenomai.xenomai.org>
List-Unsubscribe: <http://xenomai.org/mailman/options/xenomai>,
 <mailto:xenomai-request@xenomai.org?subject=unsubscribe>
List-Archive: <http://xenomai.org/pipermail/xenomai/>
List-Post: <mailto:xenomai@xenomai.org>
List-Help: <mailto:xenomai-request@xenomai.org?subject=help>
List-Subscribe: <http://xenomai.org/mailman/listinfo/xenomai>,
 <mailto:xenomai-request@xenomai.org?subject=subscribe>
To: Henning Schild <henning.schild@siemens.com>, xenomai@xenomai.org
Cc: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>

On 10/28/2015 12:15 PM, Henning Schild wrote:
> The environment variable TMPDIR is optional and not always set. We could
> test for it and fall back to /tmp/ or just use the tool mktemp.
> 
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  scripts/prepare-kernel.sh | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/prepare-kernel.sh b/scripts/prepare-kernel.sh
> index 8e960e8..333d11c 100755
> --- a/scripts/prepare-kernel.sh
> +++ b/scripts/prepare-kernel.sh
> @@ -238,9 +238,9 @@ fi
>  # Create an empty output patch file, and initialize the temporary tree.
>  if test "x$output_patch" != "x"; then
>  
> -    temp_tree=$TMPDIR/prepare-kernel-$$
> -    if ! mkdir $temp_tree; then
> -	echo Temporary directory $temp_tree already exists, aborting.
> +    temp_tree=`mktemp -d prepare-kernel-XXX --tmpdir`
> +    if [ $? -ne 0 ]; then
> +	echo Temporary directory could not be created.
>  	exit 1
>      fi
>  
> 

merged, thanks.

-- 
Philippe.