From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2 1/5] symbols: prefix static symbols with
 their source file names
Date: Wed, 28 Oct 2015 12:55:21 +0000
Message-ID: <5630C5B9.1090807@citrix.com>
References: <562E12E802000078000AE785@prv-mh.provo.novell.com>
	<562E217102000078000AE89F@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=736780ccf=Andrew.Cooper3@citrix.com>)
	id 1ZrQGE-0007ob-4i
	for xen-devel@lists.xenproject.org; Wed, 28 Oct 2015 12:55:26 +0000
In-Reply-To: <562E217102000078000AE89F@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>, Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 26/10/15 11:49, Jan Beulich wrote:
> This requires adjustments to the tool generating the symbol table and
> its as well as nm's invocation.
>
> Note: Not warning about duplicate symbols in the EFI case for now, as
> a binutils bug causes misnamed file name entries to appear in EFI
> binaries' symbol tables when the file name is longer than 18 chars.
> (Not doing so also avoids other duplicates getting printed twice.)
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Should warn_dups become fatal once the patches to fix these...

Duplicate symbol 'memory.c#get_reserved_device_memory' (ffff82d080140183
!=3D ffff82d080118b5b)
Duplicate symbol 'platform_hypercall.c#__maddr_to_virt'
(ffff82d08023a3a2 !=3D ffff82d080167e66)
Duplicate symbol 'platform_hypercall.c#__virt_to_maddr'
(ffff82d08023a401 !=3D ffff82d080167ec5)
Duplicate symbol 'platform_hypercall.c#cpumask_check' (ffff82d08023a489
!=3D ffff82d080167f4d)

have been committed, to avoid accidental reintroduction?

I note that even sysv format doesn't appear to provide directory
information, so we still cant distinguish duplicate static symbols in
identically named source files in difference directories, but hopefully
that should be very rare.

Overall, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>,
although I haven=92t vetted the symbol.c changes too carefully.

~Andrew