From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965842AbbJ1NNR (ORCPT ); Wed, 28 Oct 2015 09:13:17 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:34576 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965238AbbJ1NNO (ORCPT ); Wed, 28 Oct 2015 09:13:14 -0400 Subject: Re: [RFC PATCH net-next 2/4] perf tools: Introduce bpf-output event To: Wang Nan , acme@kernel.org, ast@kernel.org, brendan.d.gregg@gmail.com, jolsa@kernel.org References: <1446029705-199659-1-git-send-email-wangnan0@huawei.com> <1446029705-199659-3-git-send-email-wangnan0@huawei.com> Cc: lizefan@huawei.com, pi3orama@163.com, davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Alexei Starovoitov , Arnaldo Carvalho de Melo From: Sergei Shtylyov Message-ID: <5630C9E8.5090806@cogentembedded.com> Date: Wed, 28 Oct 2015 16:13:12 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1446029705-199659-3-git-send-email-wangnan0@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 10/28/2015 1:55 PM, Wang Nan wrote: > Commit a43eec304259a6c637f4014a6d4767159b6a3aa3 (bpf: introduce > bpf_perf_event_output() helper) add a helper to enable BPF program You haven't run the patch thru scripts/checkpath.pl, I guess? It now enforces the certain style of citing a commit. > output data to perf ring buffer through a new type of perf event > PERF_COUNT_SW_BPF_OUTPUT. This patch enable perf to create perf > event of that type. Now perf user can use following cmdline to > receive output data from BPF programs: > > # perf record -a -e evt=bpf-output/no-inherit/ \ > -e ./test_bpf_output.c/maps.bpf-output.event=evt/ ls > > # perf script > perf 12927 [004] 355971.129276: 0 evt=bpf-output/no-inherit/: ffffffff811ed5f1 sys_write > perf 12927 [004] 355971.129279: 0 evt=bpf-output/no-inherit/: ffffffff811ed5f1 sys_write > ... > > Signed-off-by: Wang Nan > Cc: Alexei Starovoitov > Cc: Arnaldo Carvalho de Melo > Cc: Brendan Gregg > Cc: David S. Miller > --- > tools/perf/util/evsel.c | 6 ++++++ > tools/perf/util/parse-events.c | 4 ++++ > tools/perf/util/parse-events.l | 1 + > 3 files changed, 11 insertions(+) > > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > index 397fb4e..f01defb 100644 > --- a/tools/perf/util/evsel.c > +++ b/tools/perf/util/evsel.c > @@ -224,6 +224,12 @@ struct perf_evsel *perf_evsel__new_idx(struct perf_event_attr *attr, int idx) > if (evsel != NULL) > perf_evsel__init(evsel, attr, idx); > > + if ((evsel->attr.type == PERF_TYPE_SOFTWARE) && > + (evsel->attr.config == PERF_COUNT_SW_BPF_OUTPUT)) { Inner parens not necessary here. [...] MBR, Sergei