From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Sender: =?UTF-8?Q?Krzysztof_Koz=C5=82owski?= Subject: Re: [rtc-linux] Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC To: Alexandre Belloni References: <1445863883-5187-1-git-send-email-alim.akhtar@samsung.com> <1445863883-5187-6-git-send-email-alim.akhtar@samsung.com> <56302514.4090407@samsung.com> <20151028015323.GZ28319@sirena.org.uk> <56303054.8060804@samsung.com> <56303DA3.5020306@samsung.com> <5630419F.1000300@samsung.com> <20151028094853.GM22331@piout.net> Cc: k.kozlowski.k@gmail.com, Alim Akhtar , Mark Brown , lee.jones@linaro.org, mturquette@baylibre.com, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-ID: <5630CE44.7070204@samsung.com> Date: Wed, 28 Oct 2015 22:31:48 +0900 MIME-Version: 1.0 In-Reply-To: <20151028094853.GM22331@piout.net> Content-Type: text/plain; charset=windows-1252 List-ID: W dniu 28.10.2015 o 18:48, Alexandre Belloni pisze: > On 28/10/2015 at 12:31:43 +0900, Krzysztof Kozlowski wrote : >> The s2mps13 clock driver added new name and compatible... which was >> probably totally unneeded (I missed that during review). We don't have >> to make this as a rule... >> >> Since we do not have any data about future workarounds and the >> differences then just follow Ockham's razor - use the same name and >> compatible. >> > > So you don't care about DT backward compatibility because when a > workaround will be needed for one of the IPs, then you will have to > update the old dtb to use it. Nope, DTB does not contain the name for RTC driver (s2mps15-rtc). It will be exactly the same. > > Unless you are sure that the IP is the same, doing > > { "s2mps15-rtc", S2MPS14X }, > > is probably the best way to handle that. Note that I personally don't > care about the DT ABI, I'm just pointing out what may happen ;) In case of RTC driver there is no chance of DT ABI issues here. The clock driver is different because it contain a compatible. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-x233.google.com (mail-pa0-x233.google.com. [2607:f8b0:400e:c03::233]) by gmr-mx.google.com with ESMTPS id vy6si4772668pbc.1.2015.10.28.06.31.53 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Oct 2015 06:31:53 -0700 (PDT) Received: by mail-pa0-x233.google.com with SMTP id fv9so7782400pac.3 for ; Wed, 28 Oct 2015 06:31:53 -0700 (PDT) Sender: rtc-linux@googlegroups.com Subject: Re: [rtc-linux] Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC To: Alexandre Belloni References: <1445863883-5187-1-git-send-email-alim.akhtar@samsung.com> <1445863883-5187-6-git-send-email-alim.akhtar@samsung.com> <56302514.4090407@samsung.com> <20151028015323.GZ28319@sirena.org.uk> <56303054.8060804@samsung.com> <56303DA3.5020306@samsung.com> <5630419F.1000300@samsung.com> <20151028094853.GM22331@piout.net> Cc: k.kozlowski.k@gmail.com, Alim Akhtar , Mark Brown , lee.jones@linaro.org, mturquette@baylibre.com, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-ID: <5630CE44.7070204@samsung.com> Date: Wed, 28 Oct 2015 22:31:48 +0900 MIME-Version: 1.0 In-Reply-To: <20151028094853.GM22331@piout.net> Content-Type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , W dniu 28.10.2015 o 18:48, Alexandre Belloni pisze: > On 28/10/2015 at 12:31:43 +0900, Krzysztof Kozlowski wrote : >> The s2mps13 clock driver added new name and compatible... which was >> probably totally unneeded (I missed that during review). We don't have >> to make this as a rule... >> >> Since we do not have any data about future workarounds and the >> differences then just follow Ockham's razor - use the same name and >> compatible. >> > > So you don't care about DT backward compatibility because when a > workaround will be needed for one of the IPs, then you will have to > update the old dtb to use it. Nope, DTB does not contain the name for RTC driver (s2mps15-rtc). It will be exactly the same. > > Unless you are sure that the IP is the same, doing > > { "s2mps15-rtc", S2MPS14X }, > > is probably the best way to handle that. Note that I personally don't > care about the DT ABI, I'm just pointing out what may happen ;) In case of RTC driver there is no chance of DT ABI issues here. The clock driver is different because it contain a compatible. Best regards, Krzysztof -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.