From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 580ABE00B27; Wed, 28 Oct 2015 07:23:27 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 1E6C9E007E1 for ; Wed, 28 Oct 2015 07:23:24 -0700 (PDT) Received: by wmff134 with SMTP id f134so8057455wmf.1 for ; Wed, 28 Oct 2015 07:23:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel_com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type:content-transfer-encoding; bh=XpZRSND8kBgkZb21dylpALzTYcqTM/mZO44nBpZaLmY=; b=n5aWvv+faH3+osZX81gvFN/qSqP1JbjlU55SYD7Q5xW8iQKkkgSzpFsZBtO0I4kaLU UJMjNMl2YAtLCnmWmrNJasdEFWIHzp0gri4eouGUY44HFxydq1zpr6jcP73+As6dLX8v rOREnDePXHEBTzQcR09OiZd4ydMiHyzNzIqE0m8Niu3ODmq8fO5D8/Om9Fs9wK8tlHYH GenmTNubTxB5C+bYGT75V6bwXdGBoEi6CwKGEeA9nvHKCF0oVog2p8tGSERv9u4QOMFM QieOATuZPqZzDJT5ZAoqMzuxP21YObAgqrhFV87UIMApPXZaxy4y2VZeYVayMkeLvMzQ t8aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=XpZRSND8kBgkZb21dylpALzTYcqTM/mZO44nBpZaLmY=; b=RMNYx5+ECSnxBz0yMixXFDuARf+jUvAb8IB1VX2sYZJWzFl0Xct74HLmU9loydDlHC F5H8SGxvNHaCzqUaAYo9dgJGTIMfNijnSmbbh0c83u2MgZKBD9YFhq41+xEtZzHEbn6i SdqHm+wFyBBTrehBIZK1Fm0M4O9hiWdxfFNa/vYFnibluzhSb93+6bZOr0MCxpVMWQrw gaSbgjnqm1i2E3qxdzebvrd3x+TV2NeshnebMohq5qeWnvV03BpMkVO4dRbei7qRetzg azVHAycYQzrC3Wu6yMkcUMQlhO37kELxZNGAh9ng+YfSNmMjriokscnNZkx0+wNq9pJi dBnw== X-Gm-Message-State: ALoCoQkaDqb7hSQkZ/tIGHZcSrkfdFO/4SIQ0maGRCjskA9LD+Ola56xZHl5mYYymVAgZSn5qVew X-Received: by 10.28.145.145 with SMTP id t139mr1766062wmd.0.1446042204129; Wed, 28 Oct 2015 07:23:24 -0700 (PDT) Received: from [192.168.2.10] ([83.217.123.106]) by smtp.googlemail.com with ESMTPSA id an7sm28870587wjc.44.2015.10.28.07.23.23 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Oct 2015 07:23:23 -0700 (PDT) To: toaster@yoctoproject.org References: <1445603576-19582-1-git-send-email-belen.barros.pena@linux.intel.com> From: Michael Wood Message-ID: <5630DA5A.4070501@intel.com> Date: Wed, 28 Oct 2015 14:23:22 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1445603576-19582-1-git-send-email-belen.barros.pena@linux.intel.com> Subject: Re: [PATCH] toaster: Add meaningful title tags X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Oct 2015 14:23:27 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Thanks submitted upstream with some whitespace fixes. Also added to toaster-next. Michael On 23/10/15 13:32, Belen Barros Pena wrote: > From: Belen Barros Pena > > Our title tags are all over the place, and have > no relation to the page content. > > This commit adds a meaningful title tag to each > Toaster page. > > Signed-off-by: Belen Barros Pena > --- > bitbake/lib/toaster/toastergui/templates/base.html | 4 +++- > .../lib/toaster/toastergui/templates/baseprojectpage.html | 3 +++ > bitbake/lib/toaster/toastergui/templates/bpackage.html | 1 + > .../lib/toaster/toastergui/templates/builddashboard.html | 1 + > bitbake/lib/toaster/toastergui/templates/builds.html | 1 + > .../lib/toaster/toastergui/templates/configuration.html | 1 + > bitbake/lib/toaster/toastergui/templates/configvars.html | 1 + > bitbake/lib/toaster/toastergui/templates/dirinfo.html | 1 + > bitbake/lib/toaster/toastergui/templates/importlayer.html | 1 + > bitbake/lib/toaster/toastergui/templates/landing.html | 1 + > .../toaster/toastergui/templates/landing_not_managed.html | 2 ++ > .../lib/toaster/toastergui/templates/layerdetails.html | 1 + > bitbake/lib/toaster/toastergui/templates/newproject.html | 3 +++ > .../toaster/toastergui/templates/package_detail_base.html | 11 +++++++++-- > .../templates/package_included_dependencies.html | 4 ++-- > .../toastergui/templates/package_included_detail.html | 4 ++-- > .../templates/package_included_reverse_dependencies.html | 4 ++-- > bitbake/lib/toaster/toastergui/templates/project.html | 1 + > .../lib/toaster/toastergui/templates/projectbuilds.html | 2 +- > bitbake/lib/toaster/toastergui/templates/projectconf.html | 2 +- > bitbake/lib/toaster/toastergui/templates/projects.html | 2 ++ > bitbake/lib/toaster/toastergui/templates/recipe.html | 1 + > bitbake/lib/toaster/toastergui/templates/recipes.html | 1 + > bitbake/lib/toaster/toastergui/templates/target.html | 1 + > bitbake/lib/toaster/toastergui/templates/task.html | 1 + > bitbake/lib/toaster/toastergui/templates/tasks.html | 15 ++++++++------- > .../toastergui/templates/unavailable_artifact.html | 2 ++ > bitbake/lib/toaster/toastergui/views.py | 2 +- > 28 files changed, 55 insertions(+), 19 deletions(-) > > diff --git a/bitbake/lib/toaster/toastergui/templates/base.html b/bitbake/lib/toaster/toastergui/templates/base.html > index dfa6bba..11ac2a0 100644 > --- a/bitbake/lib/toaster/toastergui/templates/base.html > +++ b/bitbake/lib/toaster/toastergui/templates/base.html > @@ -4,7 +4,9 @@ > {% load project_url_tag %} > > > - {% if objectname %} {{objectname|title}} - {% endif %}Toaster > + > + {% block title %} Toaster {% endblock %} > + > > > > diff --git a/bitbake/lib/toaster/toastergui/templates/baseprojectpage.html b/bitbake/lib/toaster/toastergui/templates/baseprojectpage.html > index 88bf859..1f45be4 100644 > --- a/bitbake/lib/toaster/toastergui/templates/baseprojectpage.html > +++ b/bitbake/lib/toaster/toastergui/templates/baseprojectpage.html > @@ -1,6 +1,9 @@ > {% extends "base.html" %} > {% load projecttags %} > {% load humanize %} > + > +{% block title %} {{title}} - {{project.name}} - Toaster {% endblock %} > + > {% block pagecontent %} > > {% include "projecttopbar.html" %} > diff --git a/bitbake/lib/toaster/toastergui/templates/bpackage.html b/bitbake/lib/toaster/toastergui/templates/bpackage.html > index d775fec..81973cb 100644 > --- a/bitbake/lib/toaster/toastergui/templates/bpackage.html > +++ b/bitbake/lib/toaster/toastergui/templates/bpackage.html > @@ -2,6 +2,7 @@ > > {% load projecttags %} > > +{% block title %} Packages built - {{build.target_set.all|dictsort:"target"|join:", "}} {{build.machine}} - {{build.project.name}} - Toaster {% endblock %} > {% block localbreadcrumb %} >
  • Packages
  • > {% endblock %} > diff --git a/bitbake/lib/toaster/toastergui/templates/builddashboard.html b/bitbake/lib/toaster/toastergui/templates/builddashboard.html > index c39fe34..323bbbb 100644 > --- a/bitbake/lib/toaster/toastergui/templates/builddashboard.html > +++ b/bitbake/lib/toaster/toastergui/templates/builddashboard.html > @@ -2,6 +2,7 @@ > {% load humanize %} > {% load projecttags %} > > +{% block title %} {{build.target_set.all|dictsort:"target"|join:", "}} {{build.machine}} - {{build.project.name}} - Toaster {% endblock %} > {% block parentbreadcrumb %} > {% if build.get_sorted_target_list.count > 0 %} > {{build.get_sorted_target_list.0.target}} > diff --git a/bitbake/lib/toaster/toastergui/templates/builds.html b/bitbake/lib/toaster/toastergui/templates/builds.html > index 459fcb0..a27a121 100644 > --- a/bitbake/lib/toaster/toastergui/templates/builds.html > +++ b/bitbake/lib/toaster/toastergui/templates/builds.html > @@ -5,6 +5,7 @@ > {% load project_url_tag %} > {% load humanize %} > > +{% block title %} All builds - Toaster {% endblock %} > {% block extraheadcontent %} > > > diff --git a/bitbake/lib/toaster/toastergui/templates/configuration.html b/bitbake/lib/toaster/toastergui/templates/configuration.html > index 3e48991..85d6a62 100644 > --- a/bitbake/lib/toaster/toastergui/templates/configuration.html > +++ b/bitbake/lib/toaster/toastergui/templates/configuration.html > @@ -1,6 +1,7 @@ > {% extends "basebuildpage.html" %} > {% load projecttags %} > > +{% block title %} Configuration summary - {{build.target_set.all|dictsort:"target"|join:", "}} {{build.machine}} - {{build.project.name}} - Toaster {% endblock %} > {% block localbreadcrumb %} >
  • Configuration
  • > {% endblock %} > diff --git a/bitbake/lib/toaster/toastergui/templates/configvars.html b/bitbake/lib/toaster/toastergui/templates/configvars.html > index 8a572ae..e40c225 100644 > --- a/bitbake/lib/toaster/toastergui/templates/configvars.html > +++ b/bitbake/lib/toaster/toastergui/templates/configvars.html > @@ -1,6 +1,7 @@ > {% extends "basebuildpage.html" %} > {% load projecttags %} > > +{% block title %} BitBake variables - {{build.target_set.all|dictsort:"target"|join:", "}} {{build.machine}} - {{build.project.name}} - Toaster {% endblock %} > {% block localbreadcrumb %} >
  • Configuration
  • > {% endblock %} > diff --git a/bitbake/lib/toaster/toastergui/templates/dirinfo.html b/bitbake/lib/toaster/toastergui/templates/dirinfo.html > index 7819894..ecb46bf 100644 > --- a/bitbake/lib/toaster/toastergui/templates/dirinfo.html > +++ b/bitbake/lib/toaster/toastergui/templates/dirinfo.html > @@ -1,4 +1,5 @@ > {% extends "basebuildpage.html" %} > +{% block title %} Directory structure - {{ target.target }} {{ build.machine }} - {{ build.project.name }} - Toaster {% endblock %} > {% block extraheadcontent %} > {% load static %} > > diff --git a/bitbake/lib/toaster/toastergui/templates/importlayer.html b/bitbake/lib/toaster/toastergui/templates/importlayer.html > index ce3d724..033f0ae 100644 > --- a/bitbake/lib/toaster/toastergui/templates/importlayer.html > +++ b/bitbake/lib/toaster/toastergui/templates/importlayer.html > @@ -2,6 +2,7 @@ > {% load projecttags %} > {% load humanize %} > {% load static %} > +{% block title %} Import layer - {{project.name}} - Toaster {% endblock %} > {% block pagecontent %} > > {% include "projecttopbar.html" %} > diff --git a/bitbake/lib/toaster/toastergui/templates/landing.html b/bitbake/lib/toaster/toastergui/templates/landing.html > index 65d8c3c..cafaa1a 100644 > --- a/bitbake/lib/toaster/toastergui/templates/landing.html > +++ b/bitbake/lib/toaster/toastergui/templates/landing.html > @@ -4,6 +4,7 @@ > {% load projecttags %} > {% load humanize %} > > +{% block title %} Welcome to Toaster {% endblock %} > {% block pagecontent %} > > {% if BUILD_MODE %} > diff --git a/bitbake/lib/toaster/toastergui/templates/landing_not_managed.html b/bitbake/lib/toaster/toastergui/templates/landing_not_managed.html > index 5bc435d..9b37f55 100644 > --- a/bitbake/lib/toaster/toastergui/templates/landing_not_managed.html > +++ b/bitbake/lib/toaster/toastergui/templates/landing_not_managed.html > @@ -4,6 +4,8 @@ > {% load projecttags %} > {% load humanize %} > > +{% block title %} Welcome to Toaster {% endblock %} > + > {% block pagecontent %} > >
    > diff --git a/bitbake/lib/toaster/toastergui/templates/layerdetails.html b/bitbake/lib/toaster/toastergui/templates/layerdetails.html > index 7dd3db2..7fe365d 100644 > --- a/bitbake/lib/toaster/toastergui/templates/layerdetails.html > +++ b/bitbake/lib/toaster/toastergui/templates/layerdetails.html > @@ -3,6 +3,7 @@ > {% load humanize %} > {% load static %} > > +{% block title %} {{layerversion.layer.name}} - {{project.name}} - Toaster {% endblock %} > {% block pagecontent %} > >
    > diff --git a/bitbake/lib/toaster/toastergui/templates/newproject.html b/bitbake/lib/toaster/toastergui/templates/newproject.html > index 997390b..e83b2be 100644 > --- a/bitbake/lib/toaster/toastergui/templates/newproject.html > +++ b/bitbake/lib/toaster/toastergui/templates/newproject.html > @@ -1,6 +1,9 @@ > {% extends "base.html" %} > {% load projecttags %} > {% load humanize %} > + > +{% block title %} Create a new project - Toaster {% endblock %} > + > {% block pagecontent %} >
    >