All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Shaohua Li <shli@fb.com>, linux-raid@vger.kernel.org
Cc: Kernel-team@fb.com, songliubraving@fb.com, hch@infradead.org,
	neilb@suse.de
Subject: Re: [PATCH] raid5-cache: use crc32c checksum
Date: Wed, 28 Oct 2015 08:26:58 -0700	[thread overview]
Message-ID: <5630E942.90501@sandisk.com> (raw)
In-Reply-To: <05c660271fe0d5f42bc053ef89c5e20ff57cf955.1445989535.git.shli@fb.com>

On 10/27/2015 04:48 PM, Shaohua Li wrote:
> crc32c has lower overhead with cpu acceleration. It's a shame I didn't
> use it in first post, sorry. This changes disk format, but we are still
> ok in current stage.

Hello Shaohua,

Although this patch looks fine to me I think the (void *) casts in the 
crc32c_le() calls can be left out. Had you considered to include that 
change in this patch ?

Thanks,

Bart.

  reply	other threads:[~2015-10-28 15:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27 23:48 [PATCH] raid5-cache: use crc32c checksum Shaohua Li
2015-10-28 15:26 ` Bart Van Assche [this message]
2015-10-28 15:41   ` Shaohua Li
2015-10-28 22:46     ` Bart Van Assche
2015-10-30  6:37       ` Neil Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5630E942.90501@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    --cc=Kernel-team@fb.com \
    --cc=hch@infradead.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=shli@fb.com \
    --cc=songliubraving@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.