From: John Crispin <blogic@openwrt.org>
To: Hauke Mehrtens <hauke@hauke-m.de>, ralf@linux-mips.org
Cc: linux-mips@linux-mips.org, Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Subject: Re: [PATCH 06/15] MIPS: lantiq: deactivate most of the devices by default
Date: Thu, 29 Oct 2015 07:18:35 +0100 [thread overview]
Message-ID: <5631BA3B.4090703@openwrt.org> (raw)
In-Reply-To: <1446071865-21936-7-git-send-email-hauke@hauke-m.de>
Hi Hauke,
read through the series a couple of times now and the only thing i can
find is a superfluous Travolta bracket
On 28/10/2015 23:37, Hauke Mehrtens wrote:
> + if (deactivate) {
> + /* Disable it during the initialitin. Module should enable when used */
> + pmu_disable(clk);
> + }
> clkdev_add(&clk->cl);
> }
i think that bracket is not needed
apart from that, for the whole series
Acked-by: John Crispin <blogic@openwrt.org>
Thanks!
next prev parent reply other threads:[~2015-10-29 6:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 22:37 [PATCH 00/15] MIPS: lantiq: add clock and PMU support for new SoCs Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 01/15] MIPS: lantiq: add locking for PMU register and check status afterwards Hauke Mehrtens
2015-10-29 11:19 ` Sergei Shtylyov
2015-10-29 19:15 ` [PATCH please merge into original " Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 02/15] MIPS: lantiq: add support for setting PMU register on AR10 and GRX390 Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 03/15] MIPS: lantiq: rename CGU_SYS_VR9 register Hauke Mehrtens
2015-10-29 19:15 ` [PATCH please merge into original " Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 04/15] MIPS: lantiq: fix pp32 clock on vr9 Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 05/15] MIPS: lantiq: add clock detection for grx390 and ar10 Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 06/15] MIPS: lantiq: deactivate most of the devices by default Hauke Mehrtens
2015-10-29 6:18 ` John Crispin [this message]
2015-10-28 22:37 ` [PATCH 07/15] MIPS: lantiq: add PMU bits for USB and SDIO devices Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 08/15] MIPS: lantiq: add pmu bits for ar10 and grx390 Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 09/15] MIPS: lantiq: add support for gphy firmware loading " Hauke Mehrtens
2015-10-29 19:16 ` [PATCH please merge into original " Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 10/15] MIPS: lantiq: add SoC detection " Hauke Mehrtens
2015-10-29 19:17 ` [PATCH please merge into original " Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 11/15] MIPS: lantiq: add clock for mei driver Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 12/15] MIPS: lantiq: add 1e103100.deu clock Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 13/15] MIPS: lantiq: add misc clocks Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 14/15] MIPS: lantiq: add support for xRX220 SoC Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 15/15] MIPS: lantiq: fix check for return value of request_mem_region() Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5631BA3B.4090703@openwrt.org \
--to=blogic@openwrt.org \
--cc=hauke.mehrtens@lantiq.com \
--cc=hauke@hauke-m.de \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.