From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tetsuya Mukawa <mukawa@igel.co.jp>
Subject: Re: [PATCH v6 2/9] null: fix segfault when null_pmd
 added to bonding
Date: Thu, 29 Oct 2015 16:19:20 +0900
Message-ID: <5631C878.8060003@igel.co.jp>
References: <1443621905-7872-1-git-send-email-tomaszx.kulasek@intel.com>
 <1444989651-6236-1-git-send-email-tomaszx.kulasek@intel.com>
 <1444989651-6236-3-git-send-email-tomaszx.kulasek@intel.com>
 <7064813.L2uCrhhELF@xps13>
 <3042915272161B4EB253DA4D77EB373A14E0C5E1@IRSMSX102.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Kulasek, TomaszX" <tomaszx.kulasek@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com
 [209.85.220.45]) by dpdk.org (Postfix) with ESMTP id 1A144378E
 for <dev@dpdk.org>; Thu, 29 Oct 2015 08:19:24 +0100 (CET)
Received: by padhy1 with SMTP id hy1so26393728pad.0
 for <dev@dpdk.org>; Thu, 29 Oct 2015 00:19:23 -0700 (PDT)
In-Reply-To: <3042915272161B4EB253DA4D77EB373A14E0C5E1@IRSMSX102.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2015/10/28 22:43, Kulasek, TomaszX wrote:
>> -----Original Message-----
>> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
>> Sent: Tuesday, October 27, 2015 17:59
>> To: Kulasek, TomaszX
>> Cc: dev@dpdk.org; Tetsuya Mukawa
>> Subject: Re: [dpdk-dev] [PATCH v6 2/9] null: fix segfault when null_pmd
>> added to bonding
>>
>> Hi,
>> There is no change in v6 for this patch which was acked by Tetsuya.
>> So why not keep the Acked-by below your Signed-off-by?
>>
>> It seems patches 2, 3, 4 and 5 were Acked by Tetsuya.
>> Other acks I'm missing?
>>
> Hi,
>
> Patches 4 and 5 were changed due to the Tetsuya's suggestions and already reviewed. There are not big changes, but I'm not sure if it should be reacked by Tetsuya, or I can just copy ack?
>
> Tomasz

Hi Tomasz,

Could you please check Bernard's patch series?
 - [PATCH v5 00/28] remove pci driver from vdevs
He tries to remove pci_drv from PMD.

It seems your below patch will be affected by his patch.
 - null: fix segfault when null_pmd added to bonding

I just wonder your bonding RSS patch works without below fixing.
drivers/net/null/rte_eth_null.c :
+       pci_dev->driver = &rte_null_pmd.pci_drv;

Anyway, Could you please check him patches?

Thanks,
Tetsuya