From: axboe@kernel.dk (Jens Axboe)
Subject: [PATCH v13 2/5] gennvm: Generic NVM manager
Date: Thu, 29 Oct 2015 16:34:55 +0900 [thread overview]
Message-ID: <5631CC1F.5050107@kernel.dk> (raw)
In-Reply-To: <56315D0F.5010602@cn.fujitsu.com>
On 10/29/2015 08:41 AM, Dongsheng Yang wrote:
> On 10/28/2015 08:30 AM, Matias Bj?rling wrote:
>> The implementation for Open-Channel SSDs is divided into media
> [...]
>> + lun->reserved_blocks = 2; /* for GC only */
>> + lun->vlun.id = i;
>> + lun->vlun.lun_id = i % dev->luns_per_chnl;
>> + lun->vlun.chnl_id = i / dev->luns_per_chnl;
>
> Please use do_div(). % would be not supported in some platforms, as
> the kbuild pointed in V12.
Neither of those are 64-bit variables, which is where you end up with
the problem on 32-bit archs.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: "Dongsheng Yang" <yangds.fnst@cn.fujitsu.com>,
"Matias Bjørling" <m@bjorling.me>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org
Cc: hch@infradead.org, jg@lightnvm.io, Stephen.Bates@pmcs.com,
keith.busch@intel.com
Subject: Re: [PATCH v13 2/5] gennvm: Generic NVM manager
Date: Thu, 29 Oct 2015 16:34:55 +0900 [thread overview]
Message-ID: <5631CC1F.5050107@kernel.dk> (raw)
In-Reply-To: <56315D0F.5010602@cn.fujitsu.com>
On 10/29/2015 08:41 AM, Dongsheng Yang wrote:
> On 10/28/2015 08:30 AM, Matias Bjørling wrote:
>> The implementation for Open-Channel SSDs is divided into media
> [...]
>> + lun->reserved_blocks = 2; /* for GC only */
>> + lun->vlun.id = i;
>> + lun->vlun.lun_id = i % dev->luns_per_chnl;
>> + lun->vlun.chnl_id = i / dev->luns_per_chnl;
>
> Please use do_div(). % would be not supported in some platforms, as
> the kbuild pointed in V12.
Neither of those are 64-bit variables, which is where you end up with
the problem on 32-bit archs.
--
Jens Axboe
next prev parent reply other threads:[~2015-10-29 7:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 0:30 [PATCH v13 0/5] Support for Open-Channel SSDs Matias Bjørling
2015-10-28 0:30 ` Matias Bjørling
2015-10-28 0:30 ` Matias Bjørling
2015-10-28 0:30 ` [PATCH v13 1/5] lightnvm: " Matias Bjørling
2015-10-28 0:30 ` Matias Bjørling
2015-10-28 0:30 ` Matias Bjørling
2015-10-28 0:30 ` [PATCH v13 2/5] gennvm: Generic NVM manager Matias Bjørling
2015-10-28 0:30 ` Matias Bjørling
2015-10-28 0:30 ` Matias Bjørling
2015-10-28 23:41 ` Dongsheng Yang
2015-10-28 23:41 ` Dongsheng Yang
2015-10-28 23:41 ` Dongsheng Yang
2015-10-29 7:34 ` Jens Axboe [this message]
2015-10-29 7:34 ` Jens Axboe
2015-10-28 0:30 ` [PATCH v13 3/5] rrpc: Round-robin sector target with cost-based gc Matias Bjørling
2015-10-28 0:30 ` Matias Bjørling
2015-10-28 0:30 ` Matias Bjørling
2015-10-28 0:30 ` [PATCH v13 4/5] null_nvm: LightNVM test driver Matias Bjørling
2015-10-28 0:30 ` Matias Bjørling
2015-10-28 0:30 ` [PATCH v13 5/5] nvme: LightNVM support Matias Bjørling
2015-10-28 0:30 ` Matias Bjørling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5631CC1F.5050107@kernel.dk \
--to=axboe@kernel.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.