From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZriZk-00086K-0v for mharc-qemu-trivial@gnu.org; Thu, 29 Oct 2015 04:28:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZriZh-00082Q-M1 for qemu-trivial@nongnu.org; Thu, 29 Oct 2015 04:28:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZriZe-0008FD-9W for qemu-trivial@nongnu.org; Thu, 29 Oct 2015 04:28:45 -0400 Received: from [59.151.112.132] (port=28660 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZriZd-0008Ck-UF; Thu, 29 Oct 2015 04:28:42 -0400 X-IronPort-AV: E=Sophos;i="5.15,520,1432569600"; d="scan'208";a="102427428" Received: from unknown (HELO edo.cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 29 Oct 2015 16:30:52 +0800 Received: from G08CNEXCHPEKD03.g08.fujitsu.local (localhost.localdomain [127.0.0.1]) by edo.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id t9T8S5oN010836; Thu, 29 Oct 2015 16:28:05 +0800 Received: from [10.167.226.38] (10.167.226.38) by G08CNEXCHPEKD03.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.181.6; Thu, 29 Oct 2015 16:28:38 +0800 To: Michael Tokarev , References: <1445761408-10308-1-git-send-email-caoj.fnst@cn.fujitsu.com> <5631CE9B.5050409@msgid.tls.msk.ru> <5631D17A.4020101@cn.fujitsu.com> <5631D3D5.7080105@msgid.tls.msk.ru> From: Cao jin Message-ID: <5631D8B3.1020104@cn.fujitsu.com> Date: Thu, 29 Oct 2015 16:28:35 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <5631D3D5.7080105@msgid.tls.msk.ru> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.226.38] X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 59.151.112.132 Cc: qemu-trivial Subject: Re: [Qemu-trivial] [PATCH] fix bad indentation in pcie_cap_slot_write_config() X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2015 08:28:46 -0000 On 10/29/2015 04:07 PM, Michael Tokarev wrote: > It is a general common sense maybe, I dunno. There's lot of code which does not > comply with the coding styles, and at the very least, when you change just that > without actually changing the code, git blame stops working, showing your non- > change for everything instead of showing actual _code_ changes. That's one of > the reasons why all qemu codebase hasn't been translated by some automatic > coding style formatting tool. > I see. Thanks for sharing the thing about "git blame", I do not know this before:) > Thanks, > > /mjt > -- Yours Sincerely, Cao Jin From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZriZj-00085b-FA for qemu-devel@nongnu.org; Thu, 29 Oct 2015 04:28:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZriZi-0008Io-Hf for qemu-devel@nongnu.org; Thu, 29 Oct 2015 04:28:47 -0400 References: <1445761408-10308-1-git-send-email-caoj.fnst@cn.fujitsu.com> <5631CE9B.5050409@msgid.tls.msk.ru> <5631D17A.4020101@cn.fujitsu.com> <5631D3D5.7080105@msgid.tls.msk.ru> From: Cao jin Message-ID: <5631D8B3.1020104@cn.fujitsu.com> Date: Thu, 29 Oct 2015 16:28:35 +0800 MIME-Version: 1.0 In-Reply-To: <5631D3D5.7080105@msgid.tls.msk.ru> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] fix bad indentation in pcie_cap_slot_write_config() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev , qemu-devel@nongnu.org Cc: qemu-trivial On 10/29/2015 04:07 PM, Michael Tokarev wrote: > It is a general common sense maybe, I dunno. There's lot of code which does not > comply with the coding styles, and at the very least, when you change just that > without actually changing the code, git blame stops working, showing your non- > change for everything instead of showing actual _code_ changes. That's one of > the reasons why all qemu codebase hasn't been translated by some automatic > coding style formatting tool. > I see. Thanks for sharing the thing about "git blame", I do not know this before:) > Thanks, > > /mjt > -- Yours Sincerely, Cao Jin