From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] tools/hotplug: xendomains.service conflicts
 with libvirt
Date: Thu, 29 Oct 2015 11:07:22 +0000
Message-ID: <5631FDEA.9080608@citrix.com>
References: <1446114165-13437-1-git-send-email-olaf@aepfle.de>
	<20151029102955.GC8097@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20151029102955.GC8097@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>, Olaf Hering <olaf@aepfle.de>
Cc: xen-devel@lists.xen.org, Ian Jackson <ian.jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 29/10/15 10:29, Wei Liu wrote:
> On Thu, Oct 29, 2015 at 10:22:45AM +0000, Olaf Hering wrote:
>> xendomains will manage guests behind libvirts back:
>> - libvirt starts a guest
>> - that guest can be "managed" by libvirt and xl at the same time
>> - when xendomains runs on shutdown it will save the guest using xl
>>   libvirt does not know about this
>> - when xendomains runs on boot it will restore the saved guest using xl
>>   libvirt does not know about this, it will just fail to manage the
>>   restored guest
>>
>> To prevent xendomains from interfering with libvirt add a Conflicts= to
>> xendomains.service. It will cause libvirt to be stopped if xendomains is
>> started manually with 'systemctl start'
>>
>> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
>> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>> Cc: Ian Campbell <ian.campbell@citrix.com>
>> Cc: Wei Liu <wei.liu2@citrix.com>
>> ---
>>
>> This never went out via git send-email, sorry about this.
>>
>>
>>  tools/hotplug/Linux/systemd/xendomains.service.in | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/hotplug/Linux/systemd/xendomains.service.in b/tools/hotplug/Linux/systemd/xendomains.service.in
>> index 66e2065..3875de1 100644
>> --- a/tools/hotplug/Linux/systemd/xendomains.service.in
>> +++ b/tools/hotplug/Linux/systemd/xendomains.service.in
>> @@ -4,6 +4,7 @@ Requires=proc-xen.mount xenstored.service
>>  After=proc-xen.mount xenstored.service xenconsoled.service xen-init-dom0.service
>>  After=network-online.target
>>  After=remote-fs.target
>> +Conflicts=libvirt.service
> Is there a canonical source for the name of service? We should reference
> that in commit message.
>
> My quick search on the Internet presents libvirtd.service as well. I
> fear the name of the service is up to distros, which means we shouldn't
> put one in xendomains.service.

If it is a service file provided by libvirt upstream, we can probably
get away with naming it explicitly.

If each distro write their own service files for libvirt, we probably can't.

~Andrew