From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent ABRIOU Subject: Re: [PATCH] drm/sti: Remove select of CONFIG_FW_LOADER_USER_HELPER_FALLBACK Date: Thu, 29 Oct 2015 15:21:35 +0100 Message-ID: <56322B6F.5080101@st.com> References: <1445235370-6717-1-git-send-email-tiwai@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4C9AA6E1D2 for ; Thu, 29 Oct 2015 07:21:44 -0700 (PDT) In-Reply-To: <1445235370-6717-1-git-send-email-tiwai@suse.de> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Takashi Iwai , Benjamin Gaignard Cc: "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org SGkgVGFrYXNoaSwKClJlbW92aW5nIEZXX0xPQURFUl9VU0VSX0hFTFBFUl9GQUxMQkFDSyBsZWFk cyB0byBhIGZhaWx1cmUgaW4gb3VyIEhRVkRQIApmaXJtd2FyZSBleGVjdXRpb24uCkluZGVlZCwg b3VyIGZpcm13YXJlIGlzIG5vdCBidWlsdC1pbi4gSXQgaXMgYSBwcm9wcmlldGFyeSBmaXJtd2Fy ZSAKdXBsb2FkZWQgaW50byB0aGUgZmlsZSBzeXN0ZW0gdGhhdCdzIHdoeSB3ZSBuZWVkIHRoZSAK VVNFUl9IRUxQRVJfRkFMTEJBQ0sgdG8gYmUgYWJsZSB0byBsb2FkIGl0IG9uY2UgZmlsZSBzeXN0 ZW0gaXMgYXZhaWxhYmxlLgoKQlIKVmluY2VudAoKT24gMTAvMTkvMjAxNSAwODoxNiBBTSwgVGFr YXNoaSBJd2FpIHdyb3RlOgo+IFRoZSBjb21taXQgWzRmZGJjNjc4ZmU0ZDogZHJtOiBzdGk6IGFk ZCBIUVZEUCBwbGFuZV0gYWRkZWQgdGhlIHNlbGVjdAo+IG9mIENPTkZJR19GV19MT0FERVJfVVNF Ul9IRUxQRVJfRkFMTEJBQ0sgYnkgc29tZSB1bndyaXR0ZW4gcmVhc29uLgo+IEJ1dCB0aGlzIGNv bmZpZyBpcyBrbm93biB0byBiZSBoYXJtZnVsLCBhbmQgaXMgcHJlc2VudCBvbmx5IGZvcgo+IGNv bXBhdGliaWxpdHkgcmVhc29uIGZvciBhbiBvbGQgZXhvdGljIHN5c3RlbSB0aGF0IG1hbmRhdGVz IHVkZXYKPiBpbnRlcmFjdGlvbiB3aGljaCBpc24ndCBzdXBwb3NlZCB0byBiZSBzZWxlY3RlZCBi eSBhIGRyaXZlci4KPiBMZXQncyByZW1vdmUgaXQuCj4KPiBGaXhlczogNGZkYmM2NzhmZTRkICgn ZHJtOiBzdGk6IGFkZCBIUVZEUCBwbGFuZScpCj4gQ2M6IDxzdGFibGVAdmdlci5rZXJuZWwub3Jn Pgo+IFNpZ25lZC1vZmYtYnk6IFRha2FzaGkgSXdhaSA8dGl3YWlAc3VzZS5kZT4KPiAtLS0KPiAg IGRyaXZlcnMvZ3B1L2RybS9zdGkvS2NvbmZpZyB8IDEgLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDEg ZGVsZXRpb24oLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vc3RpL0tjb25maWcg Yi9kcml2ZXJzL2dwdS9kcm0vc3RpL0tjb25maWcKPiBpbmRleCBmYmNjYzEwNTgxOWIuLmExODE1 OTA3NGI3NiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vc3RpL0tjb25maWcKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vc3RpL0tjb25maWcKPiBAQCAtNiw3ICs2LDYgQEAgY29uZmlnIERS TV9TVEkKPiAgIAlzZWxlY3QgRFJNX0dFTV9DTUFfSEVMUEVSCj4gICAJc2VsZWN0IERSTV9LTVNf Q01BX0hFTFBFUgo+ICAgCXNlbGVjdCBEUk1fUEFORUwKPiAtCXNlbGVjdCBGV19MT0FERVJfVVNF Ul9IRUxQRVJfRkFMTEJBQ0sKPiAgIAloZWxwCj4gICAJICBDaG9vc2UgdGhpcyBvcHRpb24gdG8g ZW5hYmxlIERSTSBvbiBTVE0gc3RpSDQxeCBjaGlwc2V0Cj4KPgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757221AbbJ2OVs (ORCPT ); Thu, 29 Oct 2015 10:21:48 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:51893 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751532AbbJ2OVr convert rfc822-to-8bit (ORCPT ); Thu, 29 Oct 2015 10:21:47 -0400 From: Vincent ABRIOU To: Takashi Iwai , Benjamin Gaignard CC: David Airlie , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Date: Thu, 29 Oct 2015 15:21:35 +0100 Subject: Re: [PATCH] drm/sti: Remove select of CONFIG_FW_LOADER_USER_HELPER_FALLBACK Thread-Topic: [PATCH] drm/sti: Remove select of CONFIG_FW_LOADER_USER_HELPER_FALLBACK Thread-Index: AdESVR59KzDhjcG+RgWSMqv1BH4BmQ== Message-ID: <56322B6F.5080101@st.com> References: <1445235370-6717-1-git-send-email-tiwai@suse.de> In-Reply-To: <1445235370-6717-1-git-send-email-tiwai@suse.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 acceptlanguage: en-US Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.15.21,1.0.33,0.0.0000 definitions=2015-10-29_09:2015-10-28,2015-10-29,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Takashi, Removing FW_LOADER_USER_HELPER_FALLBACK leads to a failure in our HQVDP firmware execution. Indeed, our firmware is not built-in. It is a proprietary firmware uploaded into the file system that's why we need the USER_HELPER_FALLBACK to be able to load it once file system is available. BR Vincent On 10/19/2015 08:16 AM, Takashi Iwai wrote: > The commit [4fdbc678fe4d: drm: sti: add HQVDP plane] added the select > of CONFIG_FW_LOADER_USER_HELPER_FALLBACK by some unwritten reason. > But this config is known to be harmful, and is present only for > compatibility reason for an old exotic system that mandates udev > interaction which isn't supposed to be selected by a driver. > Let's remove it. > > Fixes: 4fdbc678fe4d ('drm: sti: add HQVDP plane') > Cc: > Signed-off-by: Takashi Iwai > --- > drivers/gpu/drm/sti/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/sti/Kconfig b/drivers/gpu/drm/sti/Kconfig > index fbccc105819b..a18159074b76 100644 > --- a/drivers/gpu/drm/sti/Kconfig > +++ b/drivers/gpu/drm/sti/Kconfig > @@ -6,7 +6,6 @@ config DRM_STI > select DRM_GEM_CMA_HELPER > select DRM_KMS_CMA_HELPER > select DRM_PANEL > - select FW_LOADER_USER_HELPER_FALLBACK > help > Choose this option to enable DRM on STM stiH41x chipset > >