From: timur@codeaurora.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64/efi: do not assume DRAM base is aligned to 2 MB
Date: Thu, 29 Oct 2015 09:52:13 -0500 [thread overview]
Message-ID: <5632329D.3010306@codeaurora.org> (raw)
In-Reply-To: <1446127645-4115-1-git-send-email-ard.biesheuvel@linaro.org>
On 10/29/2015 09:07 AM, Ard Biesheuvel wrote:
> The current arm64 Image relocation code in the UEFI stub assumes that
> the dram_base argument it receives is always a multiple of 2 MB. In
> reality, it is simply the lowest start address of all RAM entries in
> the UEFI memory map, which means it could be any multiple of 4 KB.
>
> Since the arm64 kernel Image needs to reside TEXT_OFFSET bytes beyond
> a 2 MB aligned base, or it will fail to boot, make sure we round dram_base
> to 2 MB before using it to calculate the relocation address.
>
> Reported-by: Timur Tabi<timur@codeaurora.org>
> Acked-by: Mark Rutland<mark.rutland@arm.com>
> Signed-off-by: Ard Biesheuvel<ard.biesheuvel@linaro.org>
This works for me
Tested-by: Timur Tabi<timur@codeaurora.org>
On my system, dram_base is 0x4000820000, and *image_addr is
0x43956db000, preferred_offset is set to 0x4000880000.
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2015-10-29 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 14:07 [PATCH] arm64/efi: do not assume DRAM base is aligned to 2 MB Ard Biesheuvel
2015-10-29 14:52 ` Timur Tabi [this message]
2015-10-29 14:57 ` Will Deacon
2015-10-29 15:00 ` Timur Tabi
2015-10-29 15:21 ` Mark Rutland
2015-10-29 15:23 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5632329D.3010306@codeaurora.org \
--to=timur@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.