From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent ABRIOU Subject: Re: [PATCH] drm: sti: remove redundant sign extensions Date: Thu, 29 Oct 2015 17:10:33 +0100 Message-ID: <563244F9.1050103@st.com> References: <1445001296-23029-1-git-send-email-linux@rasmusvillemoes.dk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id BA5EF6E301 for ; Thu, 29 Oct 2015 09:10:43 -0700 (PDT) In-Reply-To: <1445001296-23029-1-git-send-email-linux@rasmusvillemoes.dk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rasmus Villemoes , Benjamin Gaignard , David Airlie Cc: "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org SGkgUmFzbXVzLAoKVGhhbmtzIGZvciB0aGUgcGF0Y2guCkkgd2lsbCBpbnRlZ3JhdGVkIGl0IGlu IHRoZSBuZXh0IHB1bGwgcmVxdWVzdCBmb3IgdGhlIHN0aSBkcml2ZXIuCgpCUgpWaW5jZW50CgpP biAxMC8xNi8yMDE1IDAzOjE0IFBNLCBSYXNtdXMgVmlsbGVtb2VzIHdyb3RlOgo+IGFyZyBpcyBs b25nIGludCwgc28gYXJnID0gKGFyZyA8PCAyMikgPj4gMjIgbWFrZXMgdGhlIHVwcGVyIDIyIGJp dHMgb2YKPiBhcmcgZXF1YWwgdG8gYml0IDkgKG9yIGJpdCA0MSkuIEJ1dCB3ZSB0aGVuIG1hc2sg YXdheSBhbGwgYnV0IGJpdHMgMC05LCBzbwo+IHRoaXMgaXMgZW50aXJlbHkgcmVkdW5kYW50Lgo+ Cj4gU2lnbmVkLW9mZi1ieTogUmFzbXVzIFZpbGxlbW9lcyA8bGludXhAcmFzbXVzdmlsbGVtb2Vz LmRrPgo+IC0tLQo+IGdjYyBzZWVtcyB0byBiZSBzbWFydCBlbm91Z2ggdG8gcmVhbGl6ZSB0aGlz IC0gdGhlIGdlbmVyYXRlZCBjb2RlIGlzCj4gdGhlIHNhbWUuIFRoaXMgaXMgdGh1cyBqdXN0IGEg dGlueSBjbGVhbnVwLgo+Cj4gICBkcml2ZXJzL2dwdS9kcm0vc3RpL3N0aV9hd2dfdXRpbHMuYyB8 IDQgLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDQgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL3N0aS9zdGlfYXdnX3V0aWxzLmMgYi9kcml2ZXJzL2dwdS9kcm0v c3RpL3N0aV9hd2dfdXRpbHMuYwo+IGluZGV4IDYwMjlhMmUzZGIxZC4uMDBkMDY5OGJlOWQzIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX2F3Z191dGlscy5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL3N0aS9zdGlfYXdnX3V0aWxzLmMKPiBAQCAtNjUsNyArNjUsNiBAQCBz dGF0aWMgaW50IGF3Z19nZW5lcmF0ZV9pbnN0cihlbnVtIG9wY29kZSBvcGNvZGUsCj4KPiAgIAkJ CW11eCA9IDA7Cj4gICAJCQlkYXRhX2VuYWJsZSA9IDA7Cj4gLQkJCWFyZyA9IChhcmcgPDwgMjIp ID4+IDIyOwo+ICAgCQkJYXJnICY9ICgweDNmZik7Cj4gICAJCQlicmVhazsKPiAgIAkJY2FzZSBS RVBFQVQ6Cj4gQEAgLTc3LDE0ICs3NiwxMiBAQCBzdGF0aWMgaW50IGF3Z19nZW5lcmF0ZV9pbnN0 cihlbnVtIG9wY29kZSBvcGNvZGUsCj4KPiAgIAkJCW11eCA9IDA7Cj4gICAJCQlkYXRhX2VuYWJs ZSA9IDA7Cj4gLQkJCWFyZyA9IChhcmcgPDwgMjIpID4+IDIyOwo+ICAgCQkJYXJnICY9ICgweDNm Zik7Cj4gICAJCQlicmVhazsKPiAgIAkJY2FzZSBKVU1QOgo+ICAgCQkJbXV4ID0gMDsKPiAgIAkJ CWRhdGFfZW5hYmxlID0gMDsKPiAgIAkJCWFyZyB8PSAweDQwOyAvKiBmb3IganVtcCBpbnN0cnVj dGlvbiA3dGggYml0IGlzIDEgKi8KPiAtCQkJYXJnID0gKGFyZyA8PCAyMikgPj4gMjI7Cj4gICAJ CQlhcmcgJj0gMHgzZmY7Cj4gICAJCQlicmVhazsKPiAgIAkJY2FzZSBTVE9QOgo+IEBAIC05NCw3 ICs5MSw2IEBAIHN0YXRpYyBpbnQgYXdnX2dlbmVyYXRlX2luc3RyKGVudW0gb3Bjb2RlIG9wY29k ZSwKPiAgIAkJY2FzZSBSUFRTRVQ6Cj4gICAJCWNhc2UgUlBMU0VUOgo+ICAgCQljYXNlIEhPTEQ6 Cj4gLQkJCWFyZyA9IChhcmcgPDwgMjQpID4+IDI0Owo+ICAgCQkJYXJnICY9ICgweDBmZik7Cj4g ICAJCQlicmVhazsKPiAgIAkJZGVmYXVsdDoKPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757742AbbJ2QKs (ORCPT ); Thu, 29 Oct 2015 12:10:48 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:59934 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757721AbbJ2QKr convert rfc822-to-8bit (ORCPT ); Thu, 29 Oct 2015 12:10:47 -0400 From: Vincent ABRIOU To: Rasmus Villemoes , Benjamin Gaignard , David Airlie CC: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Date: Thu, 29 Oct 2015 17:10:33 +0100 Subject: Re: [PATCH] drm: sti: remove redundant sign extensions Thread-Topic: [PATCH] drm: sti: remove redundant sign extensions Thread-Index: AdESZFew7gVK7RHnTC+BmicZgoLPuA== Message-ID: <563244F9.1050103@st.com> References: <1445001296-23029-1-git-send-email-linux@rasmusvillemoes.dk> In-Reply-To: <1445001296-23029-1-git-send-email-linux@rasmusvillemoes.dk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 acceptlanguage: en-US Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.15.21,1.0.33,0.0.0000 definitions=2015-10-29_10:2015-10-28,2015-10-29,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rasmus, Thanks for the patch. I will integrated it in the next pull request for the sti driver. BR Vincent On 10/16/2015 03:14 PM, Rasmus Villemoes wrote: > arg is long int, so arg = (arg << 22) >> 22 makes the upper 22 bits of > arg equal to bit 9 (or bit 41). But we then mask away all but bits 0-9, so > this is entirely redundant. > > Signed-off-by: Rasmus Villemoes > --- > gcc seems to be smart enough to realize this - the generated code is > the same. This is thus just a tiny cleanup. > > drivers/gpu/drm/sti/sti_awg_utils.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/sti/sti_awg_utils.c b/drivers/gpu/drm/sti/sti_awg_utils.c > index 6029a2e3db1d..00d0698be9d3 100644 > --- a/drivers/gpu/drm/sti/sti_awg_utils.c > +++ b/drivers/gpu/drm/sti/sti_awg_utils.c > @@ -65,7 +65,6 @@ static int awg_generate_instr(enum opcode opcode, > > mux = 0; > data_enable = 0; > - arg = (arg << 22) >> 22; > arg &= (0x3ff); > break; > case REPEAT: > @@ -77,14 +76,12 @@ static int awg_generate_instr(enum opcode opcode, > > mux = 0; > data_enable = 0; > - arg = (arg << 22) >> 22; > arg &= (0x3ff); > break; > case JUMP: > mux = 0; > data_enable = 0; > arg |= 0x40; /* for jump instruction 7th bit is 1 */ > - arg = (arg << 22) >> 22; > arg &= 0x3ff; > break; > case STOP: > @@ -94,7 +91,6 @@ static int awg_generate_instr(enum opcode opcode, > case RPTSET: > case RPLSET: > case HOLD: > - arg = (arg << 24) >> 24; > arg &= (0x0ff); > break; > default: >