Re: [Qemu-devel] [PULL v3 00/14] QMP and QObject patches

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 969 bytes --]

On 10/29/2015 12:33 PM, Markus Armbruster wrote:

>> Still doesn't build with old glib:
>>
>> In file included from /Users/pm215/src/qemu-for-merges/qga/commands.c:14:
>> In file included from
>> /Users/pm215/src/qemu-for-merges/qga/guest-agent-core.h:14:
>> In file included from /Users/pm215/src/qemu-for-merges/include/qemu-common.h:25:
>> /Users/pm215/src/qemu-for-merges/include/glib-compat.h:172:47: error:
>> expected ';' after expression
>>     g_hash_table_replace(hash_table, key, key)
>>                                               ^
>>                                               ;
>>
>> I did a trial build with the typo fixed, and that is OK, so this
>> should be the last fix required, I think.
> 
> Hand me the brown paper bag...

And me, for letting that slip by review even when I caught 'add (' on
the line above.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]