Re: can-j1939 API

[Oliver Hartkopp <socketcan@hartkopp.net>]

Hi Kurt,

On 10/23/2015 01:14 PM, Kurt Van Dijck wrote:
>>>> ...
>>>> Can you not have you module only listen on
>>>> interfaces where J1939 sockets have been opened?
>>>
>>> That sounds like a fine idea!
>>> It would behave slightly different during booting, but given the critics
>>> on the switch, this will probably the best thing to do.
>>> This implies that a non-root user decides to turn on can-j1939
>>> processing on an interface, which I found a hard nut to crack.
>>
>> I had not really considered the user permissions ramifications of
>> things. You raise a good point here.
>>
>> Doesn't SocketCAN automatically load the protocol module when you try
>> to open a socket? That means non-root users can already decide to turn
>> on processing on an interface for ISOTP etc. I am good with non-root
>> users being able to enable J1939 like this, especially if the
>> precedent is already set by other protocols.
> 
> Yep, I can follow that argument.
> When I get to it, I'll change that.
> It also implies I can drop iproute2-j1939 branches completely.
> 

Just to be sure I understood it correctly:

No iproute2-j1939 branch -> no address support for j1939 in iproute
-> no address support in af_can.c ?? \o/

So you would automatically take care of SA/Name when a j1939 socket is created
with the according address information (== per-socket), right?

Regards,
Oliver