From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757230AbbJ3Cpg (ORCPT <rfc822;w@1wt.eu>);
	Thu, 29 Oct 2015 22:45:36 -0400
Received: from szxga01-in.huawei.com ([58.251.152.64]:25414 "EHLO
	szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751017AbbJ3Cpf (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 29 Oct 2015 22:45:35 -0400
Subject: Re: [PATCH V6 2/3] Add reset controller for hi6220 SoC platform.
To: Philipp Zabel <p.zabel@pengutronix.de>
References: <1446123303-91956-1-git-send-email-puck.chen@hisilicon.com>
 <1446123303-91956-2-git-send-email-puck.chen@hisilicon.com>
 <1446135292.3274.67.camel@pengutronix.de>
CC: <linux-kernel@vger.kernel.org>, <puck.chen@aliyun.com>,
        <robh+dt@kernel.org>, <pawel.moll@arm.com>, <mark.rutland@arm.com>,
        <ijc+devicetree@hellion.org.uk>
From: chenfeng <puck.chen@hisilicon.com>
Message-ID: <5632D9BF.1080209@hisilicon.com>
Date: Fri, 30 Oct 2015 10:45:19 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <1446135292.3274.67.camel@pengutronix.de>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.142.192.172]
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 2015/10/30 0:14, Philipp Zabel wrote:
> Am Donnerstag, den 29.10.2015, 20:55 +0800 schrieb Chen Feng:
>> reset: add driver for hi6220 reset controller
> 
> Same comment as for patch 1, this should probably be the subject,
> the commit message body was better in V4.
> 
>> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
>> ---
>>  drivers/reset/Kconfig                          |   1 +
>>  drivers/reset/Makefile                         |   1 +
>>  drivers/reset/hisilicon/Kconfig                |   5 ++
>>  drivers/reset/hisilicon/Makefile               |   1 +
>>  drivers/reset/hisilicon/hi6220_reset.c         | 108 +++++++++++++++++++++++++
>>  include/dt-bindings/reset/hisi,hi6220-resets.h |  67 +++++++++++++++
> 
> Move the header file into patch 1, it is better to include this with the
> binding documentation.
> 

Thanks for your patience. I will change this and resend it.
> regards
> Philipp
> 
> 
> 
> .
>