From: glen lee <glen.lee@atmel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <gregkh@linuxfoundation.org>, <devel@driverdev.osuosl.org>,
<austin.shin@atmel.com>, <linux-wireless@vger.kernel.org>,
<Nicolas.FERRE@atmel.com>, <adel.noureldin@atmel.com>,
<tony.cho@atmel.com>, <leo.kim@atmel.com>,
<adham.abozaeid@atmel.com>
Subject: Re: [PATCH 17/17] staging: wilc1000: wilc_netdev_init: use wilc instead of g_linux_wlan
Date: Fri, 30 Oct 2015 17:50:03 +0900 [thread overview]
Message-ID: <56332F3B.5080406@atmel.com> (raw)
In-Reply-To: <20151030083544.GD18797@mwanda>
On 2015년 10월 30일 17:35, Dan Carpenter wrote:
> On Fri, Oct 30, 2015 at 12:10:42PM +0900, Glen Lee wrote:
>> /*create the common structure*/
>> - g_linux_wlan = kzalloc(sizeof(*g_linux_wlan), GFP_KERNEL);
>> - if (!g_linux_wlan)
>> + wl = kzalloc(sizeof(struct wilc), GFP_KERNEL);
> This introduces a checkpatch.pl warning. The prefered style is:
>
> wl = kzalloc(sizeof(*wl), GFP_KERNEL);
>
> But the larger point is that please use checkpatch.pl.
Thank you for the review, I will use preferred style in v2.
regards,
glen lee
>
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2015-10-30 8:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 3:10 [PATCH 01/17] staging: wilc1000: define wiphy private data priv in struct host_if_drv Glen Lee
2015-10-30 3:10 ` [PATCH 02/17] staging: wilc1000: send_config_pkt: add argument struct net_device Glen Lee
2015-10-30 3:10 ` [PATCH 03/17] staging: wilc1000: wilc_wlan_cfg_get: " Glen Lee
2015-10-30 3:10 ` [PATCH 04/17] staging: wilc1000: wilc_wlan_cfg_set: " Glen Lee
2015-10-30 3:10 ` [PATCH 05/17] staging: wilc1000: wilc_wlan_cfg_commit: " Glen Lee
2015-10-30 3:10 ` [PATCH 06/17] staging: wilc1000: wilc_wlan_txq_add_cfg_pkt: add argument net_device Glen Lee
2015-10-30 3:10 ` [PATCH 07/17] staging: wilc1000: wilc_wlan_txq_add_to_head: add new " Glen Lee
2015-10-30 3:10 ` [PATCH 08/17] staging: wilc1000: remove unused function remove_TCP_related Glen Lee
2015-10-30 3:10 ` [PATCH 09/17] staging: wilc1000: wilc_wlan_stop: add argument struct net_device Glen Lee
2015-10-30 3:10 ` [PATCH 10/17] staging: wilc1000: remove unused function wilc_wlan_global_reset Glen Lee
2015-10-30 3:10 ` [PATCH 11/17] staging: wilc1000: wilc_wlan_firmware_download: add argument net_device Glen Lee
2015-10-30 3:10 ` [PATCH 12/17] staging: wilc1000: chip_sleep_manually: add argument struct net_device Glen Lee
2015-10-30 3:10 ` [PATCH 13/17] staging: wilc1000: wilc_wlan_start: " Glen Lee
2015-10-30 3:10 ` [PATCH 14/17] staging: wilc1000: acquire_bus: add new argument struct wilc Glen Lee
2015-10-30 3:10 ` [PATCH 15/17] staging: wilc1000: release_bus: add " Glen Lee
2015-10-30 3:10 ` [PATCH 16/17] staging: wilc1000: linux_wlan_get_num_conn_ifcs: add argument net_device Glen Lee
2015-10-30 3:10 ` [PATCH 17/17] staging: wilc1000: wilc_netdev_init: use wilc instead of g_linux_wlan Glen Lee
2015-10-30 8:35 ` Dan Carpenter
2015-10-30 8:50 ` glen lee [this message]
2015-11-02 1:43 ` About the patch "Staging: wilc1000: coreconfigurator: Drop unneeded wrapper functions" glen lee
2015-11-03 8:26 ` Shivani Bhardwaj
2015-11-03 8:59 ` glen lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56332F3B.5080406@atmel.com \
--to=glen.lee@atmel.com \
--cc=Nicolas.FERRE@atmel.com \
--cc=adel.noureldin@atmel.com \
--cc=adham.abozaeid@atmel.com \
--cc=austin.shin@atmel.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=leo.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=tony.cho@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.