From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031098AbbJ3MKf (ORCPT ); Fri, 30 Oct 2015 08:10:35 -0400 Received: from mga14.intel.com ([192.55.52.115]:51699 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030890AbbJ3MKd (ORCPT ); Fri, 30 Oct 2015 08:10:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,218,1444719600"; d="scan'208";a="838797956" Message-ID: <56335F56.7020202@linux.intel.com> Date: Fri, 30 Oct 2015 14:15:18 +0200 From: Mathias Nyman User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Lu Baolu , Mathias Nyman , Greg Kroah-Hartman CC: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/1] usb: xhci: fix checking ep busy for CFC References: <1446128660-8303-1-git-send-email-baolu.lu@linux.intel.com> In-Reply-To: <1446128660-8303-1-git-send-email-baolu.lu@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.10.2015 16:24, Lu Baolu wrote: > Function ep_ring_is_processing() checks the dequeue pointer > in endpoint context to know whether an endpoint is busy with > processing TRBs. This is not correct since dequeue pointer > field in an endpoint context is only valid when the endpoint > is in Halted or Stopped states. This buggy code causes audio > noise when playing sound with USB headset connected to host > controllers which support CFC (one of xhci 1.1 features). > > This patch should exist in stable kernel since v4.3. > > Reported-and-tested-by: YD Tseng > Signed-off-by: Lu Baolu > --- > v1->v2: > Implement the logic in xhci_queue_isoc_tx_prepare() instead of > a seperated function as suggested by Mathias. > > v2->v3: > Add the missing {} pair found by Sergei. > Adjust line for code readability as suggested by Mathias. > --- Thanks Added to queue with stable tag for v4.3 Will send forward once 4.4-rc1 is out -Mathias