From: "Hunt, David" <david.hunt@intel.com>
To: Jan Viktorin <viktorin@rehivetech.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2 3/6] eal/arm: add 64-bit armv8 version of rte_cycles.h
Date: Fri, 30 Oct 2015 13:18:17 +0000 [thread overview]
Message-ID: <56336E19.2020004@intel.com> (raw)
In-Reply-To: <20151030134456.4bedfb2e@pcviktorin.fit.vutbr.cz>
On 30/10/2015 12:44, Jan Viktorin wrote:
> On Fri, 30 Oct 2015 11:51:23 +0000
> David Hunt <david.hunt@intel.com> wrote:
>
>> +static inline uint64_t
>> +rte_rdtsc(void)
>> +{
>> + uint64_t tsc;
>> +
>> + asm volatile("mrs %0, CNTVCT_EL0" : "=r" (tsc));
>> +
>> +#ifdef RTE_TIMER_MULTIPLIER
>> + return tsc * RTE_TIMER_MULTIPLIER;
>> +#else
>
> I think, this should be CONFIG_RTE_TIMER_MULTIPLIER.
>
> Jan
Jan,
Thanks for the super-fast review :)
I've taken a look at this and RTE_TIMER_MULTIPLIER is present in
the generated include/rte_config.h, so it compiles and run fine. I've
also confirmed this by removing the #ifdef, forcing the use of
RTE_TIMER_MULTIPLIER as a test.
Dave.
next prev parent reply other threads:[~2015-10-30 13:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 11:51 [PATCH v2 0/6] ARMv8 additions to ARMv7 support David Hunt
2015-10-30 11:51 ` [PATCH v2 1/6] eal/arm: add 64-bit armv8 version of rte_memcpy.h David Hunt
2015-10-30 11:51 ` [PATCH v2 2/6] eal/arm: add 64-bit armv8 version of rte_prefetch.h David Hunt
2015-10-30 11:51 ` [PATCH v2 3/6] eal/arm: add 64-bit armv8 version of rte_cycles.h David Hunt
2015-10-30 12:44 ` Jan Viktorin
2015-10-30 13:18 ` Hunt, David [this message]
2015-10-30 11:51 ` [PATCH v2 4/6] eal/arm: fix 64-bit armv8 compilation of rte_cpuflags.h David Hunt
2015-10-30 12:46 ` Jan Viktorin
2015-10-30 11:51 ` [PATCH v2 5/6] mk: add support for armv8 on top of armv7 David Hunt
2015-10-30 12:49 ` Jan Viktorin
2015-10-30 11:51 ` [PATCH v2 6/6] test: add checks for cpu flags on armv8 David Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56336E19.2020004@intel.com \
--to=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.