Re: [PATCH 2/5] ipr: Clear NO_ULEN_CHK bit when resource is a vset.

[Manoj Kumar <manoj@linux.vnet.ibm.com>]

On 10/30/2015 11:49 AM, Gabriel Krisman Bertazi wrote:
>
>   	if (ipr_is_gscsi(res) || ipr_is_vset_device(res)) {
> -		if (scsi_cmd->underflow == 0)
> +		if (scsi_cmd->underflow == 0 && !ipr_is_vset_device(res))

This section is getting quite convoluted. If there isn't really that
much common between ipr_is_gscsi(res) and ipr_is_vset_device(res)
anymore, it would read much better as distinct segments:

if (ipr_is_gscsi(res))
...
if (ipr_is_vset_devices(res))
...

This will avoid having multiple calls to ipr_is_gscsi() and
ipr_is_vset_device() in the same section of code.

---
Manoj Kumar