From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86: make compat_iret() domain crash cases
	distinguishable
Date: Fri, 30 Oct 2015 19:05:38 +0000
Message-ID: <5633BF82.2000301@citrix.com>
References: <5633BB0802000078000B0613@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=738c1b259=Andrew.Cooper3@citrix.com>)
	id 1ZsEze-0002W3-PA
	for xen-devel@lists.xenproject.org; Fri, 30 Oct 2015 19:05:42 +0000
In-Reply-To: <5633BB0802000078000B0613@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 30/10/15 17:46, Jan Beulich wrote:
> Rather than issuing a (mostly) useless separate message, rely on
> domain_crash() providing enough data, and leverage the line number
> information it prints.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

The messages are not completely useless, and they do save a round-trip
to the debug symbols (which can be a very long RTT when dealing with
customers).

I agree that moving the domain_crash()'s is a good idea, but can we get
away with just demoing the gprintk()s to gdprintk()s ?

~Andrew