From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] x86: make compat_iret() domain crash cases distinguishable Date: Fri, 30 Oct 2015 19:11:22 +0000 Message-ID: <5633C0DA.5080402@citrix.com> References: <5633BB0802000078000B0613@prv-mh.provo.novell.com> <5633BF82.2000301@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZsF5D-0002oT-HZ for xen-devel@lists.xenproject.org; Fri, 30 Oct 2015 19:11:27 +0000 In-Reply-To: <5633BF82.2000301@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Keir Fraser List-Id: xen-devel@lists.xenproject.org On 30/10/15 19:05, Andrew Cooper wrote: > On 30/10/15 17:46, Jan Beulich wrote: >> Rather than issuing a (mostly) useless separate message, rely on >> domain_crash() providing enough data, and leverage the line number >> information it prints. >> >> Signed-off-by: Jan Beulich > The messages are not completely useless, and they do save a round-trip > to the debug symbols (which can be a very long RTT when dealing with > customers). > > I agree that moving the domain_crash()'s is a good idea, but can we get > away with just demoing the gprintk()s to gdprintk()s ? Apologies - this review text was intended for "[PATCH] x86: simplify do_iret() domain crashing". I replied to the wrong email. This patch "[PATCH] x86: make compat_iret() domain crash cases distinguishable" is Reviewed-by: Andrew Cooper