From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] cpufreq: allow ordinary boolean options to
 be passed on the command line
Date: Fri, 30 Oct 2015 19:22:22 +0000
Message-ID: <5633C36E.7040508@citrix.com>
References: <5633BBAB02000078000B0617@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2048540198780889163=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=738c1b259=Andrew.Cooper3@citrix.com>)
	id 1ZsFFz-0003Aa-7L
	for xen-devel@lists.xenproject.org; Fri, 30 Oct 2015 19:22:35 +0000
In-Reply-To: <5633BBAB02000078000B0617@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Jinsong Liu <jinsong.liu@alibaba-inc.com>
List-Id: xen-devel@lists.xenproject.org

--===============2048540198780889163==
Content-Type: multipart/alternative;
	boundary="------------020605040703000702020304"

--------------020605040703000702020304
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit

On 30/10/15 17:49, Jan Beulich wrote:
> I was quite surprised to find "cpufreq=off" not doing what one would
> expect it to do. Fix this.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/docs/misc/xen-command-line.markdown
> +++ b/docs/misc/xen-command-line.markdown
> @@ -391,11 +391,12 @@ If set, force use of the performance cou
>  available support.
>  
>  ### cpufreq
> -> `= dom0-kernel | none | xen[,[powersave|performance|ondemand|userspace][,<maxfreq>][,[<minfreq>][,[verbose]]]]`
> +> `= none | {{ <boolean> | xen } [:[powersave|performance|ondemand|userspace][,<maxfreq>][,[<minfreq>][,[verbose]]]]} | dom0-kernel`

If I am reading the parsing correctly below, the insertion if ':' is to
match the previous behaviour? (or have I missed something?)

~Andrew

>  
>  > Default: `xen`
>  
> -Indicate where the responsibility for driving power states lies.
> +Indicate where the responsibility for driving power states lies.  Note that the
> +choice of `dom0-kernel` is deprecated and not supported by all Dom0 kernels.
>  
>  * Default governor policy is ondemand.
>  * `<maxfreq>` and `<minfreq>` are integers which represent max and min processor frequencies
> --- a/xen/drivers/cpufreq/cpufreq.c
> +++ b/xen/drivers/cpufreq/cpufreq.c
> @@ -64,9 +64,14 @@ enum cpufreq_controller cpufreq_controll
>  
>  static void __init setup_cpufreq_option(char *str)
>  {
> -    char *arg;
> +    char *arg = strpbrk(str, ",:");
> +    int choice;
>  
> -    if ( !strcmp(str, "dom0-kernel") )
> +    if ( arg )
> +        *arg++ = '\0';
> +    choice = parse_bool(str);
> +
> +    if ( choice < 0 && !strcmp(str, "dom0-kernel") )
>      {
>          xen_processor_pmbits &= ~XEN_PROCESSOR_PM_PX;
>          cpufreq_controller = FREQCTL_dom0_kernel;
> @@ -74,19 +79,20 @@ static void __init setup_cpufreq_option(
>          return;
>      }
>  
> -    if ( !strcmp(str, "none") )
> +    if ( choice == 0 || !strcmp(str, "none") )
>      {
>          xen_processor_pmbits &= ~XEN_PROCESSOR_PM_PX;
>          cpufreq_controller = FREQCTL_none;
>          return;
>      }
>  
> -    if ( (arg = strpbrk(str, ",:")) != NULL )
> -        *arg++ = '\0';
> -
> -    if ( !strcmp(str, "xen") )
> +    if ( choice > 0 || !strcmp(str, "xen") )
> +    {
> +        xen_processor_pmbits |= XEN_PROCESSOR_PM_PX;
> +        cpufreq_controller = FREQCTL_xen;
>          if ( arg && *arg )
>              cpufreq_cmdline_parse(arg);
> +    }
>  }
>  custom_param("cpufreq", setup_cpufreq_option);
>  
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel


--------------020605040703000702020304
Content-Type: text/html; charset="windows-1252"
Content-Transfer-Encoding: 7bit

<html>
  <head>
    <meta content="text/html; charset=windows-1252"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">On 30/10/15 17:49, Jan Beulich wrote:<br>
    </div>
    <blockquote
      cite="mid:5633BBAB02000078000B0617@prv-mh.provo.novell.com"
      type="cite">
      <pre wrap="">I was quite surprised to find "cpufreq=off" not doing what one would
expect it to do. Fix this.

Signed-off-by: Jan Beulich <a class="moz-txt-link-rfc2396E" href="mailto:jbeulich@suse.com">&lt;jbeulich@suse.com&gt;</a>

--- a/docs/misc/xen-command-line.markdown
+++ b/docs/misc/xen-command-line.markdown
@@ -391,11 +391,12 @@ If set, force use of the performance cou
 available support.
 
 ### cpufreq
-&gt; `= dom0-kernel | none | xen[,[powersave|performance|ondemand|userspace][,&lt;maxfreq&gt;][,[&lt;minfreq&gt;][,[verbose]]]]`
+&gt; `= none | {{ &lt;boolean&gt; | xen } [:[powersave|performance|ondemand|userspace][,&lt;maxfreq&gt;][,[&lt;minfreq&gt;][,[verbose]]]]} | dom0-kernel`</pre>
    </blockquote>
    <br>
    If I am reading the parsing correctly below, the insertion if ':' is
    to match the previous behaviour? (or have I missed something?)<br>
    <br>
    ~Andrew<br>
    <br>
    <blockquote
      cite="mid:5633BBAB02000078000B0617@prv-mh.provo.novell.com"
      type="cite">
      <pre wrap="">
 
 &gt; Default: `xen`
 
-Indicate where the responsibility for driving power states lies.
+Indicate where the responsibility for driving power states lies.  Note that the
+choice of `dom0-kernel` is deprecated and not supported by all Dom0 kernels.
 
 * Default governor policy is ondemand.
 * `&lt;maxfreq&gt;` and `&lt;minfreq&gt;` are integers which represent max and min processor frequencies
--- a/xen/drivers/cpufreq/cpufreq.c
+++ b/xen/drivers/cpufreq/cpufreq.c
@@ -64,9 +64,14 @@ enum cpufreq_controller cpufreq_controll
 
 static void __init setup_cpufreq_option(char *str)
 {
-    char *arg;
+    char *arg = strpbrk(str, ",:");
+    int choice;
 
-    if ( !strcmp(str, "dom0-kernel") )
+    if ( arg )
+        *arg++ = '\0';
+    choice = parse_bool(str);
+
+    if ( choice &lt; 0 &amp;&amp; !strcmp(str, "dom0-kernel") )
     {
         xen_processor_pmbits &amp;= ~XEN_PROCESSOR_PM_PX;
         cpufreq_controller = FREQCTL_dom0_kernel;
@@ -74,19 +79,20 @@ static void __init setup_cpufreq_option(
         return;
     }
 
-    if ( !strcmp(str, "none") )
+    if ( choice == 0 || !strcmp(str, "none") )
     {
         xen_processor_pmbits &amp;= ~XEN_PROCESSOR_PM_PX;
         cpufreq_controller = FREQCTL_none;
         return;
     }
 
-    if ( (arg = strpbrk(str, ",:")) != NULL )
-        *arg++ = '\0';
-
-    if ( !strcmp(str, "xen") )
+    if ( choice &gt; 0 || !strcmp(str, "xen") )
+    {
+        xen_processor_pmbits |= XEN_PROCESSOR_PM_PX;
+        cpufreq_controller = FREQCTL_xen;
         if ( arg &amp;&amp; *arg )
             cpufreq_cmdline_parse(arg);
+    }
 }
 custom_param("cpufreq", setup_cpufreq_option);
 



</pre>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">_______________________________________________
Xen-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Xen-devel@lists.xen.org">Xen-devel@lists.xen.org</a>
<a class="moz-txt-link-freetext" href="http://lists.xen.org/xen-devel">http://lists.xen.org/xen-devel</a>
</pre>
    </blockquote>
    <br>
  </body>
</html>

--------------020605040703000702020304--


--===============2048540198780889163==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============2048540198780889163==--