Re: [Qemu-devel] [PATCH v3 2/2] qemu-iotests: fix -valgrind option for check

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]

On 30.10.2015 20:25, Jeff Cody wrote:
> Commit 934659c switched the iotests to run qemu-io from a bash subshell,
> in order to catch segfaults.  This method is incompatible with the
> current valgrind_qemu_io() bash function.
> 
> Move the valgrind usage into the exec subshell in _qemu_io_wrapper(),
> while making sure the original return value is passed back to the
> caller.
> 
> Update test output for tests 039, 061, and 137 as it looks for the
> specific subshell command when the process is terminated.
> 
> Reported-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
>  tests/qemu-iotests/039.out       | 30 +++++++++++++++++++++++++-----
>  tests/qemu-iotests/061.out       | 12 ++++++++++--
>  tests/qemu-iotests/137.out       |  6 +++++-
>  tests/qemu-iotests/common        |  9 ++-------
>  tests/qemu-iotests/common.config | 18 +++++++++++++++++-
>  tests/qemu-iotests/common.rc     | 10 ----------
>  6 files changed, 59 insertions(+), 26 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]