From: Timur Tabi <timur@codeaurora.org>
To: Arnd Bergmann <arnd@arndb.de>, Sinan Kaya <okaya@codeaurora.org>
Cc: dmaengine@vger.kernel.org, cov@codeaurora.org, jcm@redhat.com,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Vinod Koul <vinod.koul@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dma: add Qualcomm Technologies HIDMA channel driver
Date: Fri, 30 Oct 2015 17:36:45 -0500 [thread overview]
Message-ID: <5633F0FD.7060506@codeaurora.org> (raw)
In-Reply-To: <4552697.VhjWnxQoIo@wuerfel>
On 10/30/2015 05:28 PM, Arnd Bergmann wrote:
>>> > >Why ENODEV? Could you make this handle restarted system calls?
>> >
>> >This is the self test code. It gets called from probe. If there is a
>> >problem with the device or system configuration, I don't want to enable
>> >this device. I can certainly return a different error code though.
>> >What's a good code?
> I see. probe() is not restartable, so it cannot be -ERESTARTSYS.
>
> Maybe better use wait_event_timeout and not handle the signals then.
> It will eventually time out if something goes wrong.
What about -EPROBE_DEFER? Isn't that "restartable"? Granted, it's only
supposed to be used if the driver is dependent on another driver to
probe, so I'm not sure it applies here. If the self-test fails, then it
is possible that it could succeed later?
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2015-10-30 22:36 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 3:08 [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver Sinan Kaya
2015-10-30 3:08 ` Sinan Kaya
2015-10-30 3:08 ` [PATCH 2/2] dma: add Qualcomm Technologies HIDMA channel driver Sinan Kaya
2015-10-30 8:01 ` kbuild test robot
2015-10-30 8:01 ` kbuild test robot
2015-10-30 10:24 ` Arnd Bergmann
2015-10-30 21:42 ` Sinan Kaya
2015-10-30 21:42 ` Sinan Kaya
[not found] ` <5633E442.3010003-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-10-30 21:55 ` Timur Tabi
2015-10-30 21:55 ` Timur Tabi
[not found] ` <5633E744.6040202-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-10-30 22:47 ` Arnd Bergmann
2015-10-30 22:47 ` Arnd Bergmann
2015-10-30 22:28 ` Arnd Bergmann
2015-10-30 22:36 ` Timur Tabi [this message]
2015-10-30 22:50 ` Arnd Bergmann
2015-10-31 1:53 ` Sinan Kaya
2015-11-01 18:50 ` Sinan Kaya
2015-11-01 18:50 ` Sinan Kaya
[not found] ` <56365F0D.6010508-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-11-01 20:21 ` Timur Tabi
2015-11-01 20:21 ` Timur Tabi
[not found] ` <56367433.60806-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-11-01 20:27 ` Sinan Kaya
2015-11-01 20:27 ` Sinan Kaya
2015-11-02 16:33 ` Arnd Bergmann
2015-11-02 16:33 ` Arnd Bergmann
2015-11-02 19:21 ` Sinan Kaya
[not found] ` <5637B7C1.2070200-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-11-02 20:55 ` Arnd Bergmann
2015-11-02 20:55 ` Arnd Bergmann
2015-11-03 5:29 ` Sinan Kaya
2015-11-03 10:43 ` Arnd Bergmann
2015-11-03 21:07 ` Sinan Kaya
2015-11-03 21:07 ` Sinan Kaya
2015-11-03 21:10 ` Arnd Bergmann
[not found] ` <1446174501-8870-2-git-send-email-okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-10-30 8:07 ` kbuild test robot
2015-10-30 8:07 ` kbuild test robot
2015-10-30 14:50 ` Mark Rutland
2015-10-30 14:50 ` Mark Rutland
2015-10-31 4:27 ` Sinan Kaya
2015-10-30 4:34 ` [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver kbuild test robot
2015-10-30 4:34 ` kbuild test robot
[not found] ` <1446174501-8870-1-git-send-email-okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-10-30 4:34 ` [PATCH] dma: fix platform_no_drv_owner.cocci warnings kbuild test robot
2015-10-30 4:34 ` kbuild test robot
2015-10-30 15:00 ` [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver Mark Rutland
2015-10-30 15:00 ` Mark Rutland
2015-10-30 17:59 ` Andy Shevchenko
2015-10-30 17:59 ` Andy Shevchenko
[not found] ` <CAHp75VdHxGC841cFY3M+ujZKSX04nT4+7gc3iKsgwzLRC4AYWQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-30 18:08 ` Sinan Kaya
2015-10-30 18:08 ` Sinan Kaya
2015-10-30 18:18 ` Mark Rutland
[not found] ` <5633B207.5030505-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-10-30 18:18 ` Andy Shevchenko
2015-10-30 18:18 ` Andy Shevchenko
2015-10-30 18:25 ` Mark Rutland
2015-10-30 18:25 ` Mark Rutland
2015-10-30 18:40 ` Andy Shevchenko
2015-10-30 18:40 ` Andy Shevchenko
[not found] ` <CAHp75Vd-z22XJboxQ=CMxDQ9UaTatbCmpAPLO0jPM0FwJadBOg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-30 18:48 ` Sinan Kaya
2015-10-30 18:48 ` Sinan Kaya
[not found] ` <5633BB66.3070505-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-10-30 19:01 ` Mark Rutland
2015-10-30 19:01 ` Mark Rutland
2015-10-30 20:08 ` Al Stone
[not found] ` <5633CE23.7060303-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-10-30 20:15 ` Andy Shevchenko
2015-10-30 20:15 ` Andy Shevchenko
2015-10-30 20:18 ` Mark Rutland
[not found] ` <CAHp75VcQ6r2FGqsP2mtnv95etCGJmeQ=T7aKSB5H3cvwhdSbDw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-31 3:33 ` Jon Masters
2015-10-31 3:33 ` Jon Masters
2015-10-31 17:34 ` Sinan Kaya
2015-10-30 19:36 ` Sinan Kaya
2015-10-31 17:11 ` Sinan Kaya
2015-10-30 9:34 ` Arnd Bergmann
2015-10-31 6:51 ` Sinan Kaya
2015-10-31 6:51 ` Sinan Kaya
2015-10-31 12:53 ` Timur Tabi
2015-10-31 12:53 ` Timur Tabi
2015-11-02 21:30 ` Arnd Bergmann
2015-11-03 4:45 ` Sinan Kaya
2015-11-03 4:45 ` Sinan Kaya
2015-11-03 12:42 ` Arnd Bergmann
2015-11-03 14:26 ` Timur Tabi
2015-11-03 14:26 ` Timur Tabi
2015-11-04 1:04 ` Sinan Kaya
2015-11-04 1:04 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5633F0FD.7060506@codeaurora.org \
--to=timur@codeaurora.org \
--cc=arnd@arndb.de \
--cc=cov@codeaurora.org \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jcm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=okaya@codeaurora.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.