From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751984AbbJ3Xpc (ORCPT ); Fri, 30 Oct 2015 19:45:32 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:36034 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750848AbbJ3Xpa (ORCPT ); Fri, 30 Oct 2015 19:45:30 -0400 Subject: Re: [PATCH v2] fs/block_dev.c: Remove WARN_ON() when inode writeback fails To: Jeff Moyer References: Cc: Vivek Goyal , tj@kernel.org, linux-kernel@vger.kernel.org From: Jens Axboe Message-ID: <56340117.5000103@kernel.dk> Date: Fri, 30 Oct 2015 17:45:27 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/30/2015 09:34 AM, Jeff Moyer wrote: > From: Vivek Goyal > > If a block device is hot removed and later last reference to device > is put, we try to writeback the dirty inode. But device is gone and > that writeback fails. > > Currently we do a WARN_ON() which does not seem to be the right thing. > Convert it to a ratelimited kernel warning. Any concerns with putting this into 4.4 and marking it for stable? Would be awesome to have a "Fixes:" in here too. -- Jens Axboe