From: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: <david@sigma-star.at>, <dedekind1@gmail.com>, <richard@nod.at>,
<linux-mtd@lists.infradead.org>
Subject: Re: [RESEND PATCH v2 01/27] mtd-utils: Restructure the mtd-utils source.
Date: Sat, 31 Oct 2015 10:38:20 +0800 [thread overview]
Message-ID: <5634299C.6090301@cn.fujitsu.com> (raw)
In-Reply-To: <20151027230007.GB64073@google.com>
On 10/28/2015 07:00 AM, Brian Norris wrote:
> On Thu, Oct 15, 2015 at 12:10:08PM +0800, Dongsheng Yang wrote:
>> * There is no code modification in this commit, only moving
>> * the files to proper place.
>>
>> The user tools looks a little messy as we place almost
>> the all tools in the root directory of mtd-utils. To make
>> it more clear, I propose to introduce the following structure
>> for our source code.
>>
>> mtd-utils/
>> |-- lib
>> |-- include
>> |-- misc-utils
>> |-- flash-utils
>
> What's the difference between flash-utils and misc-utils? And don't just
> tell me it's because they were named starting with "flash" :)
Haha, I am afraid yes.
>
> Particularly, I think things like "mtdpart" and "flash_erase" are pretty
> similar levels of generic.
Agreed, I thought the flash_xxx is working in lower level than mtd_xxx.
But I found I was wrong. The are in a similar level. I will move
flash_xxx to misc-utils then.
>
> (Also, why is mtdinfo in ubi-utils still? It should be moved, IMO.)
This would be done after this restructure, then we have to move some
header files from ubi-utils to the top level and then move mtdinfo to
misc-utils.
>
>> |-- jffsX-utils
>
> What makes more sense: jffsX or just jffs?
Hmmmm, I prefer jffsX for jffs and jffs2.
>
>> |-- nand-utils
>> |-- nor-utils
>
> What are specific to NOR flash? I don't even know what "rfddump" and
> "rfdformat" are. Do they really deserve their own directory?
I just read the helper of them "Formats NOR flash for resident flash
disk". Then I think there should be a nor-utils at the same time
with nand-utils.
>
>> |-- ubi-utils
>> |-- ubifs-utils
>> `-- tests
>
> You need to update .gitignore too.
Oh, yes, will update it.
TBH, I am not familiar with the *all* tools in our mtd-utils, so
I sent a RFC out to get more information for what I am not sure
about. But unfortunately, no response except yours.
I will send a V2 soon.
Thanx
Yang
>
> Brian
> .
>
next prev parent reply other threads:[~2015-10-31 2:45 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 4:04 [PATCH v2 00/27] Introduce ubifs_dump in ubifs-utils Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 01/27] mtd-utils: Restructure the mtd-utils source Dongsheng Yang
2015-10-15 4:06 ` Dongsheng Yang
2015-10-15 4:10 ` [RESEND PATCH " Dongsheng Yang
2015-10-27 23:00 ` Brian Norris
2015-10-31 2:38 ` Dongsheng Yang [this message]
2015-10-31 3:12 ` [PATCH V3 " Dongsheng Yang
2015-11-11 22:30 ` Brian Norris
2015-11-11 22:40 ` Brian Norris
2015-11-12 7:20 ` Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 02/27] ubifs: pick some common definitions into ubifs_common.h Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 03/27] ubifs: move the all io related code into io.[h|c] Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 04/27] ubifs: remove the including of mkfs.ubifs.h in lpt.c Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 05/27] ubifs: cut off the dependence from compr.o to mkfs.ubifs Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 06/27] ubifs: cut off the dependence from devtable to mkfs.ubifs.h Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 07/27] ubifs: introduce ubifs-utils/include and ubifs-utils/lib Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 08/27] ubifs: move more functions into io lib Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 09/27] ubifs: introduce a new tool ubifs_dump Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 10/27] ubifs: introduce list.h Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 11/27] ubifs: copy some important data in ubifs.h from kernel to ubifs-utils Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 12/27] ubifs: copy some important functions in key.h " Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 13/27] ubifs: ubifs_dump: add dump_ch and dump_node functions Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 14/27] ubifs: defs.h: introduce some compatible definition for printk class Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 15/27] ubifs: io: introduce ubifs_read function to read ubi volume Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 16/27] ubifs: ubifs_dump: dump super block Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 17/27] ubifs: introduce scan for ubifs-utils Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 18/27] ubifs: add some more compatible definitions in defs.h Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 19/27] ubifs: ubifs_dump: dump master node Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 20/27] ubifs: ubifs_dump: dump log area Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 21/27] ubifs: introduce lprops lib Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 22/27] ubifs: lpt: implement functions to scan lpt Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 23/27] ubifs: ubifs_dump: dump lpt area Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 24/27] ubifs: ubifs_dump: dump index area Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 25/27] ubifs: defs.h: introduce some compatible definitions about integer such as __u16 Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 26/27] ubifs: introduce hexdump lib Dongsheng Yang
2015-10-15 4:04 ` [PATCH v2 27/27] ubifs: ubifs_dump: dump data in hex format Dongsheng Yang
2015-10-31 3:13 ` [PATCH] gitignore: add ubifs_dump to gitignore Dongsheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5634299C.6090301@cn.fujitsu.com \
--to=yangds.fnst@cn.fujitsu.com \
--cc=computersforpeace@gmail.com \
--cc=david@sigma-star.at \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.